From 8d1dab4c7a7d0d33b702279897437492f25b0557 Mon Sep 17 00:00:00 2001 From: Brian Garland Date: Tue, 24 Apr 2018 15:03:47 -0700 Subject: [PATCH 1/3] enabled native props with use of FocusZone --- .../src/components/OverflowSet/OverflowSet.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.tsx b/packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.tsx index a8167f57d85e0..29804e4164588 100644 --- a/packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.tsx +++ b/packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.tsx @@ -53,6 +53,7 @@ export class OverflowSet extends BaseComponent implements } else { Tag = FocusZone; uniqueComponentProps = { + ...getNativeProps(this.props, divProperties), ...focusZoneProps, componentRef: this._focusZone, direction: vertical ? FocusZoneDirection.vertical : FocusZoneDirection.horizontal From 201a36541d8d82a18cf8d31e7cf86ca5be0f46c4 Mon Sep 17 00:00:00 2001 From: Brian Garland Date: Tue, 24 Apr 2018 15:07:45 -0700 Subject: [PATCH 2/3] added documentation for native props to OverflowSet --- .../src/components/OverflowSet/OverflowSetPage.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSetPage.tsx b/packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSetPage.tsx index d8a3e0e83da17..08c7b3415f178 100644 --- a/packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSetPage.tsx +++ b/packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSetPage.tsx @@ -29,6 +29,7 @@ export class OverflowSetPage extends React.Component('!raw-loader!office-ui-fabric-react/src/components/OverflowSet/docs/OverflowSetOverview.md') } } + allowNativeProps={ true } exampleCards={ From c29106a8ed66658d75e2eeea17e806aebaab2ed7 Mon Sep 17 00:00:00 2001 From: Brian Garland Date: Tue, 24 Apr 2018 15:09:14 -0700 Subject: [PATCH 3/3] rush change --- ...overflowset-nativeprops-3707_2018-04-24-22-09.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/office-ui-fabric-react/overflowset-nativeprops-3707_2018-04-24-22-09.json diff --git a/common/changes/office-ui-fabric-react/overflowset-nativeprops-3707_2018-04-24-22-09.json b/common/changes/office-ui-fabric-react/overflowset-nativeprops-3707_2018-04-24-22-09.json new file mode 100644 index 0000000000000..4b66c93692a3a --- /dev/null +++ b/common/changes/office-ui-fabric-react/overflowset-nativeprops-3707_2018-04-24-22-09.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "Enabled native props (aria-* and data-*) on OverflowSet even when the doNotContainWithinFocusZone prop is false", + "type": "minor" + } + ], + "packageName": "office-ui-fabric-react", + "email": "v-brgarl@microsoft.com" +} \ No newline at end of file