From c2ce9d663e4ffe3176b49ec98fc2ae168ef37636 Mon Sep 17 00:00:00 2001 From: Pramod Chandoria Date: Thu, 10 May 2018 16:26:03 -0700 Subject: [PATCH 1/4] Breaking types dependency from ContextualMenu class --- .../src/components/ContextualMenu/ContextualMenu.types.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.types.ts b/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.types.ts index be148d2028326f..e8c2527c7d564e 100644 --- a/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.types.ts +++ b/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.types.ts @@ -1,5 +1,4 @@ import * as React from 'react'; -import { ContextualMenu } from './ContextualMenu'; import { DirectionalHint } from '../../common/DirectionalHint'; import { FocusZoneDirection, IFocusZoneProps } from '../../FocusZone'; import { IIconProps } from '../Icon/Icon.types'; @@ -29,7 +28,7 @@ export interface IContextualMenu { } -export interface IContextualMenuProps extends React.Props, IWithResponsiveModeState { +export interface IContextualMenuProps extends React.Props, IWithResponsiveModeState { /** * Optional callback to access the IContextualMenu interface. Use this instead of ref for accessing * the public methods and properties of the component. From 8f12cf1dc6890c630fc32379a86cf1e0a935dff1 Mon Sep 17 00:00:00 2001 From: Pramod Chandoria Date: Thu, 10 May 2018 16:46:47 -0700 Subject: [PATCH 2/4] remove refernece from IContextualMenuSection as well --- .../src/components/ContextualMenu/ContextualMenu.types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.types.ts b/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.types.ts index e8c2527c7d564e..a2f341c0e54728 100644 --- a/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.types.ts +++ b/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.types.ts @@ -488,7 +488,7 @@ export interface IContextualMenuItem { inactive?: boolean; } -export interface IContextualMenuSection extends React.Props { +export interface IContextualMenuSection extends React.Props { /** * The items to include inside the section. From 679a4a13bc941cb9c7b211351912877edf9aa5d2 Mon Sep 17 00:00:00 2001 From: Pramod Chandoria Date: Thu, 10 May 2018 17:54:17 -0700 Subject: [PATCH 3/4] rush change --- ...chandoria-contextualMenu-fix_2018-05-11-00-54.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/office-ui-fabric-react/pchandoria-contextualMenu-fix_2018-05-11-00-54.json diff --git a/common/changes/office-ui-fabric-react/pchandoria-contextualMenu-fix_2018-05-11-00-54.json b/common/changes/office-ui-fabric-react/pchandoria-contextualMenu-fix_2018-05-11-00-54.json new file mode 100644 index 00000000000000..67f876df51fb5b --- /dev/null +++ b/common/changes/office-ui-fabric-react/pchandoria-contextualMenu-fix_2018-05-11-00-54.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "Breaking BaseButton Types dependency from ContextualMenu class", + "type": "patch" + } + ], + "packageName": "office-ui-fabric-react", + "email": "pramod.chandoria@hotmail.com" +} \ No newline at end of file From fec4269000735386380c714628aa2d180cefa19a Mon Sep 17 00:00:00 2001 From: Pramod Chandoria Date: Thu, 10 May 2018 18:24:25 -0700 Subject: [PATCH 4/4] comment the code for usage of any to be removed soon --- .../src/components/ContextualMenu/ContextualMenu.types.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.types.ts b/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.types.ts index a2f341c0e54728..9ef9b679d018d2 100644 --- a/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.types.ts +++ b/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.types.ts @@ -28,6 +28,9 @@ export interface IContextualMenu { } +/** + * React.Props is deprecated and we're removing it in 6.0. Usage of 'any' should go away with it. + */ export interface IContextualMenuProps extends React.Props, IWithResponsiveModeState { /** * Optional callback to access the IContextualMenu interface. Use this instead of ref for accessing @@ -488,6 +491,9 @@ export interface IContextualMenuItem { inactive?: boolean; } +/** + * React.Props is deprecated and we're removing it in 6.0. Usage of 'any' should go away with it. + */ export interface IContextualMenuSection extends React.Props { /**