From 84f555f048c88bce6c5d8cbef7841db5cfc8fd9a Mon Sep 17 00:00:00 2001 From: Aniket Handa Date: Wed, 3 Aug 2016 18:27:31 -0700 Subject: [PATCH 1/4] Update example icons, change selected item bg --- .../ContextualMenu/ContextualMenu.scss | 2 +- .../examples/ContextualMenu.Basic.Example.tsx | 18 ++++---- .../ContextualMenu.Checkmarks.Example.tsx | 12 ++--- .../ContextualMenu.Customization.Example.tsx | 46 +++++++++---------- .../ContextualMenu.Directional.Example.tsx | 12 ++--- 5 files changed, 45 insertions(+), 45 deletions(-) diff --git a/src/components/ContextualMenu/ContextualMenu.scss b/src/components/ContextualMenu/ContextualMenu.scss index fd66561a750c06..2ba4196fb678cd 100644 --- a/src/components/ContextualMenu/ContextualMenu.scss +++ b/src/components/ContextualMenu/ContextualMenu.scss @@ -2,7 +2,7 @@ $ContextualMenu-background: $ms-color-white; $ContextualMenu-itemHover: $ms-color-neutralLight; -$ContextualMenu-expandedItemBackground: $ms-color-themeLight; +$ContextualMenu-expandedItemBackground: $ms-color-neutralQuaternaryAlt; $ContextualMenu-itemHeight: 40px; $ContextualMenu-iconWidth: 24px; diff --git a/src/demo/pages/ContextualMenuPage/examples/ContextualMenu.Basic.Example.tsx b/src/demo/pages/ContextualMenuPage/examples/ContextualMenu.Basic.Example.tsx index 2f24a49662a4f8..7cfff47aecde7b 100644 --- a/src/demo/pages/ContextualMenuPage/examples/ContextualMenu.Basic.Example.tsx +++ b/src/demo/pages/ContextualMenuPage/examples/ContextualMenu.Basic.Example.tsx @@ -26,7 +26,7 @@ export class ContextualMenuBasicExample extends React.Component { [ { key: 'newItem', - icon: 'circlePlus', + icon: 'CirclePlus', items: [ { key: 'emailMessage', @@ -41,7 +41,7 @@ export class ContextualMenuBasicExample extends React.Component { }, { key: 'upload', - icon: 'upload', + icon: 'Upload', name: 'Upload' }, { @@ -67,12 +67,12 @@ export class ContextualMenuBasicExample extends React.Component { }, { key: 'share', - icon: 'share', + icon: 'Share', items: [ { key: 'sharetoemail', name: 'Share to Email', - icon: 'mail' + icon: 'Mail' }, { key: 'sharetofacebook', @@ -81,12 +81,12 @@ export class ContextualMenuBasicExample extends React.Component { { key: 'sharetotwitter', name: 'Share to Twitter', - icon: 'share', + icon: 'Share', items: [ { key: 'sharetoemail_1', name: 'Share to Email', - icon: 'mail' + icon: 'Mail' }, { key: 'sharetofacebook_1', @@ -95,7 +95,7 @@ export class ContextualMenuBasicExample extends React.Component { { key: 'sharetotwitter_1', name: 'Share to Twitter', - icon: 'share' + icon: 'Share' }, ], }, @@ -104,12 +104,12 @@ export class ContextualMenuBasicExample extends React.Component { }, { key: 'print', - icon: 'print', + icon: 'Print', name: 'Print' }, { key: 'music', - icon: 'music', + icon: 'MusicInCollectionFill', name: 'Music', }, { diff --git a/src/demo/pages/ContextualMenuPage/examples/ContextualMenu.Checkmarks.Example.tsx b/src/demo/pages/ContextualMenuPage/examples/ContextualMenu.Checkmarks.Example.tsx index 31daeb39ef727a..c9dcd1f12051e8 100644 --- a/src/demo/pages/ContextualMenuPage/examples/ContextualMenu.Checkmarks.Example.tsx +++ b/src/demo/pages/ContextualMenuPage/examples/ContextualMenu.Checkmarks.Example.tsx @@ -40,7 +40,7 @@ export class ContextualMenuCheckmarksExample extends React.Component Date: Wed, 3 Aug 2016 18:53:45 -0700 Subject: [PATCH 2/4] aligning icons --- src/components/ContextualMenu/ContextualMenu.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/components/ContextualMenu/ContextualMenu.scss b/src/components/ContextualMenu/ContextualMenu.scss index 2ba4196fb678cd..76ead49458c771 100644 --- a/src/components/ContextualMenu/ContextualMenu.scss +++ b/src/components/ContextualMenu/ContextualMenu.scss @@ -72,6 +72,8 @@ $ContextualMenu-iconWidth: 24px; min-height: 1px; width: $ContextualMenu-iconWidth; text-align: center; + padding-top: 12px; + vertical-align: top; } .ms-ContextualMenu-itemText { From 216d4a90948950b60271fde1923a49d192997305 Mon Sep 17 00:00:00 2001 From: Aniket Handa Date: Wed, 3 Aug 2016 19:06:40 -0700 Subject: [PATCH 3/4] Fix example --- .../ContextualMenuPage/examples/ContextualMenuExample.scss | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/demo/pages/ContextualMenuPage/examples/ContextualMenuExample.scss b/src/demo/pages/ContextualMenuPage/examples/ContextualMenuExample.scss index 83762b9af212f2..5925a430314502 100644 --- a/src/demo/pages/ContextualMenuPage/examples/ContextualMenuExample.scss +++ b/src/demo/pages/ContextualMenuPage/examples/ContextualMenuExample.scss @@ -14,13 +14,12 @@ position: absolute; vertical-align: top; width: 300px; - top: 85px; + top: 108px; margin: 0 100px; text-align: center; } .ms-ContextualMenuDirectionalExample-buttonArea .ms-Button { - top: 80px; text-align: center; width: 100%; } From 16f21e5f30f015502bad7d55972a7c446cf91abc Mon Sep 17 00:00:00 2001 From: Aniket Handa Date: Wed, 3 Aug 2016 19:33:38 -0700 Subject: [PATCH 4/4] Using semantic variables --- src/components/ContextualMenu/ContextualMenu.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/ContextualMenu/ContextualMenu.scss b/src/components/ContextualMenu/ContextualMenu.scss index 76ead49458c771..85bf5d3d2db706 100644 --- a/src/components/ContextualMenu/ContextualMenu.scss +++ b/src/components/ContextualMenu/ContextualMenu.scss @@ -72,7 +72,7 @@ $ContextualMenu-iconWidth: 24px; min-height: 1px; width: $ContextualMenu-iconWidth; text-align: center; - padding-top: 12px; + padding-top: ($ContextualMenu-itemHeight - $ms-font-size-m) / 2; vertical-align: top; }