From 2106ba88e2194876c8e89c0d6ffa96518501ef86 Mon Sep 17 00:00:00 2001 From: Jeff Hellesen Date: Tue, 29 Jan 2019 13:05:00 -0800 Subject: [PATCH 1/3] Correct issue where ESC does not work in Popups by adding tabindex to popup --- packages/office-ui-fabric-react/src/components/Popup/Popup.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/office-ui-fabric-react/src/components/Popup/Popup.tsx b/packages/office-ui-fabric-react/src/components/Popup/Popup.tsx index 753bdbee1f003..13e0cf39d83c0 100644 --- a/packages/office-ui-fabric-react/src/components/Popup/Popup.tsx +++ b/packages/office-ui-fabric-react/src/components/Popup/Popup.tsx @@ -68,6 +68,7 @@ export class Popup extends BaseComponent { return (
Date: Tue, 29 Jan 2019 13:06:43 -0800 Subject: [PATCH 2/3] Add changefile --- .../u-jehell-popup-tabindex_2019-01-29-21-05.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/office-ui-fabric-react/u-jehell-popup-tabindex_2019-01-29-21-05.json diff --git a/common/changes/office-ui-fabric-react/u-jehell-popup-tabindex_2019-01-29-21-05.json b/common/changes/office-ui-fabric-react/u-jehell-popup-tabindex_2019-01-29-21-05.json new file mode 100644 index 0000000000000..3168b8c8dfe58 --- /dev/null +++ b/common/changes/office-ui-fabric-react/u-jehell-popup-tabindex_2019-01-29-21-05.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "Support ESC after clicking in Popup", + "type": "patch" + } + ], + "packageName": "office-ui-fabric-react", + "email": "jehell@microsoft.com" +} \ No newline at end of file From aede6923ddcce729c56d5cb46338e8569f352687 Mon Sep 17 00:00:00 2001 From: Jeff Hellesen Date: Tue, 29 Jan 2019 13:49:20 -0800 Subject: [PATCH 3/3] Add snapshot updates for popup z-index addition --- .../src/components/Callout/__snapshots__/Callout.test.tsx.snap | 1 + .../components/HoverCard/__snapshots__/HoverCard.test.tsx.snap | 2 ++ .../src/components/Modal/__snapshots__/Modal.test.tsx.snap | 1 + .../src/components/Panel/__snapshots__/Panel.test.tsx.snap | 1 + .../TeachingBubble/__snapshots__/TeachingBubble.test.tsx.snap | 1 + .../src/components/Tooltip/__snapshots__/Tooltip.test.tsx.snap | 1 + .../__snapshots__/Panel.HiddenOnDismiss.Example.tsx.shot | 1 + 7 files changed, 8 insertions(+) diff --git a/packages/office-ui-fabric-react/src/components/Callout/__snapshots__/Callout.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Callout/__snapshots__/Callout.test.tsx.snap index 373c84383415f..238bb1b209023 100644 --- a/packages/office-ui-fabric-react/src/components/Callout/__snapshots__/Callout.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Callout/__snapshots__/Callout.test.tsx.snap @@ -57,6 +57,7 @@ exports[`Callout renders Callout correctly 1`] = ` "overflowY": undefined, } } + tabIndex={-1} > Content
diff --git a/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap b/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap index b48130ddd2211..efed650967fac 100644 --- a/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap @@ -134,6 +134,7 @@ exports[`HoverCard renders ExpandingCard correctly 1`] = ` "overflowY": "hidden", } } + tabIndex={-1} >