diff --git a/common/changes/@uifabric/file-type-icons/changes5_2018-12-03-17-16.json b/common/changes/@uifabric/file-type-icons/changes5_2018-12-03-17-16.json deleted file mode 100644 index 3d5520b6a25587..00000000000000 --- a/common/changes/@uifabric/file-type-icons/changes5_2018-12-03-17-16.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/file-type-icons", - "type": "none" - } - ], - "packageName": "@uifabric/file-type-icons", - "email": "Humberto.Morimoto@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/file-type-icons/just_2019-01-10-17-17.json b/common/changes/@uifabric/file-type-icons/just_2019-01-10-17-17.json deleted file mode 100644 index 4f0663f9220a56..00000000000000 --- a/common/changes/@uifabric/file-type-icons/just_2019-01-10-17-17.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/file-type-icons", - "type": "none" - } - ], - "packageName": "@uifabric/file-type-icons", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/file-type-icons/justified_2019-01-07-06-54.json b/common/changes/@uifabric/file-type-icons/justified_2019-01-07-06-54.json deleted file mode 100644 index 4f0663f9220a56..00000000000000 --- a/common/changes/@uifabric/file-type-icons/justified_2019-01-07-06-54.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/file-type-icons", - "type": "none" - } - ], - "packageName": "@uifabric/file-type-icons", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/file-type-icons/stackExperiment_2018-12-07-22-48.json b/common/changes/@uifabric/file-type-icons/stackExperiment_2018-12-07-22-48.json deleted file mode 100644 index 3d5520b6a25587..00000000000000 --- a/common/changes/@uifabric/file-type-icons/stackExperiment_2018-12-07-22-48.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/file-type-icons", - "type": "none" - } - ], - "packageName": "@uifabric/file-type-icons", - "email": "Humberto.Morimoto@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/styling/codepen-example-data_2019-01-22-22-14.json b/common/changes/@uifabric/styling/codepen-example-data_2019-01-22-22-14.json deleted file mode 100644 index 495be6e7c088a0..00000000000000 --- a/common/changes/@uifabric/styling/codepen-example-data_2019-01-22-22-14.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/styling", - "type": "none" - } - ], - "packageName": "@uifabric/styling", - "email": "elcraig@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/test-utilities/codepen-example-data_2019-01-22-22-14.json b/common/changes/@uifabric/test-utilities/codepen-example-data_2019-01-22-22-14.json deleted file mode 100644 index da748c4a9b90b0..00000000000000 --- a/common/changes/@uifabric/test-utilities/codepen-example-data_2019-01-22-22-14.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/test-utilities", - "type": "none" - } - ], - "packageName": "@uifabric/test-utilities", - "email": "elcraig@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/test-utilities/just_2019-01-10-17-17.json b/common/changes/@uifabric/test-utilities/just_2019-01-10-17-17.json deleted file mode 100644 index 389565beb153d9..00000000000000 --- a/common/changes/@uifabric/test-utilities/just_2019-01-10-17-17.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/test-utilities", - "type": "none" - } - ], - "packageName": "@uifabric/test-utilities", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/test-utilities/justified_2019-01-07-06-54.json b/common/changes/@uifabric/test-utilities/justified_2019-01-07-06-54.json deleted file mode 100644 index 389565beb153d9..00000000000000 --- a/common/changes/@uifabric/test-utilities/justified_2019-01-07-06-54.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/test-utilities", - "type": "none" - } - ], - "packageName": "@uifabric/test-utilities", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/test-utilities/pnpm_2018-11-29-05-11.json b/common/changes/@uifabric/test-utilities/pnpm_2018-11-29-05-11.json deleted file mode 100644 index da748c4a9b90b0..00000000000000 --- a/common/changes/@uifabric/test-utilities/pnpm_2018-11-29-05-11.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/test-utilities", - "type": "none" - } - ], - "packageName": "@uifabric/test-utilities", - "email": "elcraig@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/test-utilities/start_2019-01-11-20-27.json b/common/changes/@uifabric/test-utilities/start_2019-01-11-20-27.json deleted file mode 100644 index 389565beb153d9..00000000000000 --- a/common/changes/@uifabric/test-utilities/start_2019-01-11-20-27.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/test-utilities", - "type": "none" - } - ], - "packageName": "@uifabric/test-utilities", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/test-utilities/starttest_2019-01-08-23-10.json b/common/changes/@uifabric/test-utilities/starttest_2019-01-08-23-10.json deleted file mode 100644 index 389565beb153d9..00000000000000 --- a/common/changes/@uifabric/test-utilities/starttest_2019-01-08-23-10.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/test-utilities", - "type": "none" - } - ], - "packageName": "@uifabric/test-utilities", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/test-utilities/styled-fix_2018-11-14-05-15.json b/common/changes/@uifabric/test-utilities/styled-fix_2018-11-14-05-15.json deleted file mode 100644 index 2d7aff2196a87a..00000000000000 --- a/common/changes/@uifabric/test-utilities/styled-fix_2018-11-14-05-15.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/test-utilities", - "type": "none" - } - ], - "packageName": "@uifabric/test-utilities", - "email": "dzearing@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/theme-samples/codepen-example-data_2019-01-22-22-14.json b/common/changes/@uifabric/theme-samples/codepen-example-data_2019-01-22-22-14.json deleted file mode 100644 index 76b2552a14f31d..00000000000000 --- a/common/changes/@uifabric/theme-samples/codepen-example-data_2019-01-22-22-14.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/theme-samples", - "type": "none" - } - ], - "packageName": "@uifabric/theme-samples", - "email": "elcraig@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/variants/changes5_2018-12-03-17-16.json b/common/changes/@uifabric/variants/changes5_2018-12-03-17-16.json deleted file mode 100644 index b8074b9f27c041..00000000000000 --- a/common/changes/@uifabric/variants/changes5_2018-12-03-17-16.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/variants", - "type": "none" - } - ], - "packageName": "@uifabric/variants", - "email": "Humberto.Morimoto@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/variants/codepen-example-data_2019-01-22-22-14.json b/common/changes/@uifabric/variants/codepen-example-data_2019-01-22-22-14.json deleted file mode 100644 index 4db7f1fea17954..00000000000000 --- a/common/changes/@uifabric/variants/codepen-example-data_2019-01-22-22-14.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/variants", - "type": "none" - } - ], - "packageName": "@uifabric/variants", - "email": "elcraig@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/variants/just_2019-01-10-17-17.json b/common/changes/@uifabric/variants/just_2019-01-10-17-17.json deleted file mode 100644 index 1ca8b3ed20f514..00000000000000 --- a/common/changes/@uifabric/variants/just_2019-01-10-17-17.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/variants", - "type": "none" - } - ], - "packageName": "@uifabric/variants", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/variants/justified_2019-01-07-06-54.json b/common/changes/@uifabric/variants/justified_2019-01-07-06-54.json deleted file mode 100644 index 1ca8b3ed20f514..00000000000000 --- a/common/changes/@uifabric/variants/justified_2019-01-07-06-54.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/variants", - "type": "none" - } - ], - "packageName": "@uifabric/variants", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/variants/keco-npmignore-images_2018-12-06-23-46.json b/common/changes/@uifabric/variants/keco-npmignore-images_2018-12-06-23-46.json deleted file mode 100644 index e69884c9b2ee65..00000000000000 --- a/common/changes/@uifabric/variants/keco-npmignore-images_2018-12-06-23-46.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "packageName": "@uifabric/variants", - "comment": "Add image file types to .npmignore.", - "type": "none" - } - ], - "packageName": "@uifabric/variants", - "email": "keco@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/variants/stackExperiment_2018-12-07-22-48.json b/common/changes/@uifabric/variants/stackExperiment_2018-12-07-22-48.json deleted file mode 100644 index b8074b9f27c041..00000000000000 --- a/common/changes/@uifabric/variants/stackExperiment_2018-12-07-22-48.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/variants", - "type": "none" - } - ], - "packageName": "@uifabric/variants", - "email": "Humberto.Morimoto@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/variants/starttest_2019-01-08-23-10.json b/common/changes/@uifabric/variants/starttest_2019-01-08-23-10.json deleted file mode 100644 index 1ca8b3ed20f514..00000000000000 --- a/common/changes/@uifabric/variants/starttest_2019-01-08-23-10.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/variants", - "type": "none" - } - ], - "packageName": "@uifabric/variants", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/webpack-utils/just-all_2018-12-16-22-03.json b/common/changes/@uifabric/webpack-utils/just-all_2018-12-16-22-03.json deleted file mode 100644 index 4ac083be11b649..00000000000000 --- a/common/changes/@uifabric/webpack-utils/just-all_2018-12-16-22-03.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/webpack-utils", - "type": "none" - } - ], - "packageName": "@uifabric/webpack-utils", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/webpack-utils/justified_2019-01-07-06-54.json b/common/changes/@uifabric/webpack-utils/justified_2019-01-07-06-54.json deleted file mode 100644 index 4ac083be11b649..00000000000000 --- a/common/changes/@uifabric/webpack-utils/justified_2019-01-07-06-54.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/webpack-utils", - "type": "none" - } - ], - "packageName": "@uifabric/webpack-utils", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/office-ui-fabric-react/choicegroup-fix_2019-01-25-04-32.json b/common/changes/office-ui-fabric-react/choicegroup-fix_2019-01-25-04-32.json new file mode 100644 index 00000000000000..2faaf5c586860d --- /dev/null +++ b/common/changes/office-ui-fabric-react/choicegroup-fix_2019-01-25-04-32.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "ChoiceGroup: fixing issue when nested in FocusZones.", + "type": "patch" + } + ], + "packageName": "office-ui-fabric-react", + "email": "dzearing@microsoft.com" +} \ No newline at end of file diff --git a/common/changes/office-ui-fabric-react/choicegroup-fix_2019-02-20-20-00.json b/common/changes/office-ui-fabric-react/choicegroup-fix_2019-02-20-20-00.json new file mode 100644 index 00000000000000..cbcc213a8fd6e7 --- /dev/null +++ b/common/changes/office-ui-fabric-react/choicegroup-fix_2019-02-20-20-00.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "ChoiceGroup: now works again in FocusZone, but this also reverts a bug fix which allowed FocusTrapZones to behave better with ChoiceGroups in them. We will fix this issue separately. Popup: no longer has `tabindex=\"-1\"` specified, which is causing all sorts of regressions wrt FocusTrapZone usage.", + "type": "minor" + } + ], + "packageName": "office-ui-fabric-react", + "email": "dzearing@microsoft.com" +} \ No newline at end of file diff --git a/packages/office-ui-fabric-react/src/components/Callout/__snapshots__/Callout.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Callout/__snapshots__/Callout.test.tsx.snap index 721a0b64af6bde..8750c19fb98345 100644 --- a/packages/office-ui-fabric-react/src/components/Callout/__snapshots__/Callout.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Callout/__snapshots__/Callout.test.tsx.snap @@ -58,7 +58,6 @@ exports[`Callout renders Callout correctly 1`] = ` "overflowY": undefined, } } - tabIndex={-1} > Content diff --git a/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx b/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx index f27c549442098a..e68f555aabc775 100644 --- a/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx +++ b/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx @@ -81,11 +81,6 @@ export class ChoiceGroupBase extends BaseComponent !option.disabled); - const keyDefaultFocusable = keyChecked === undefined && firstEnabledOption ? firstEnabledOption.key : undefined; - return (
@@ -100,7 +95,6 @@ export class ChoiceGroupBase extends BaseComponent { expect((choiceOptions[0] as HTMLInputElement).checked).toEqual(false); expect((choiceOptions[1] as HTMLInputElement).checked).toEqual(false); expect((choiceOptions[2] as HTMLInputElement).checked).toEqual(false); - expect((choiceOptions[0] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('true'); - expect((choiceOptions[1] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); - expect((choiceOptions[2] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); ReactTestUtils.Simulate.change(choiceOptions[0]); expect((choiceOptions[0] as HTMLInputElement).checked).toEqual(true); expect((choiceOptions[1] as HTMLInputElement).checked).toEqual(false); expect((choiceOptions[2] as HTMLInputElement).checked).toEqual(false); - expect((choiceOptions[0] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('true'); - expect((choiceOptions[1] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); - expect((choiceOptions[2] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); ReactTestUtils.Simulate.change(choiceOptions[1]); expect((choiceOptions[0] as HTMLInputElement).checked).toEqual(false); expect((choiceOptions[1] as HTMLInputElement).checked).toEqual(true); expect((choiceOptions[2] as HTMLInputElement).checked).toEqual(false); - expect((choiceOptions[0] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); - expect((choiceOptions[1] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('true'); - expect((choiceOptions[2] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); ReactTestUtils.Simulate.change(choiceOptions[0]); expect((choiceOptions[0] as HTMLInputElement).checked).toEqual(true); expect((choiceOptions[1] as HTMLInputElement).checked).toEqual(false); expect((choiceOptions[2] as HTMLInputElement).checked).toEqual(false); - expect((choiceOptions[0] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('true'); - expect((choiceOptions[1] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); - expect((choiceOptions[2] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); }); it('An individual choice option can be disabled', () => { @@ -87,9 +75,6 @@ describe('ChoiceGroup', () => { expect((choiceOptions[0] as HTMLInputElement).disabled).toEqual(true); expect((choiceOptions[1] as HTMLInputElement).disabled).toEqual(false); expect((choiceOptions[2] as HTMLInputElement).disabled).toEqual(false); - expect((choiceOptions[0] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); - expect((choiceOptions[1] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('true'); - expect((choiceOptions[2] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); }); it('renders all choice options as disabled when disabled', () => { @@ -100,9 +85,6 @@ describe('ChoiceGroup', () => { expect((choiceOptions[0] as HTMLInputElement).disabled).toEqual(true); expect((choiceOptions[1] as HTMLInputElement).disabled).toEqual(true); expect((choiceOptions[2] as HTMLInputElement).disabled).toEqual(true); - expect((choiceOptions[0] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); - expect((choiceOptions[1] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); - expect((choiceOptions[2] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); }); it('can act as an uncontrolled component', () => { @@ -192,10 +174,4 @@ describe('ChoiceGroup', () => { expect(choiceGroupRef.current!.checkedOption).toBeDefined(); expect(choiceGroupRef.current!.checkedOption).toEqual(TEST_OPTIONS[0]); }); - - it('sets the first enabled option to focusable, even with an invalid defaultSelectedKey', () => { - const choiceGroup = mount(); - const choiceOptions = choiceGroup.getDOMNode().querySelectorAll(QUERY_SELECTOR); - expect((choiceOptions[0] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('true'); - }); }); diff --git a/packages/office-ui-fabric-react/src/components/ChoiceGroup/__snapshots__/ChoiceGroup.test.tsx.snap b/packages/office-ui-fabric-react/src/components/ChoiceGroup/__snapshots__/ChoiceGroup.test.tsx.snap index 20494efd1e6e93..f865a189cd530f 100644 --- a/packages/office-ui-fabric-react/src/components/ChoiceGroup/__snapshots__/ChoiceGroup.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/ChoiceGroup/__snapshots__/ChoiceGroup.test.tsx.snap @@ -98,7 +98,6 @@ exports[`ChoiceGroup label does not have className prop from parent 1`] = ` top: 8px; } data-automation-id="auto1" - data-is-focusable={true} id="ChoiceGroup0-1" name="ChoiceGroup0" onBlur={[Function]} @@ -212,7 +211,6 @@ exports[`ChoiceGroup label does not have className prop from parent 1`] = ` position: absolute; top: 8px; } - data-is-focusable={false} id="ChoiceGroup0-2" name="ChoiceGroup0" onBlur={[Function]} @@ -326,7 +324,6 @@ exports[`ChoiceGroup label does not have className prop from parent 1`] = ` position: absolute; top: 8px; } - data-is-focusable={false} id="ChoiceGroup0-3" name="ChoiceGroup0" onBlur={[Function]} @@ -470,7 +467,6 @@ exports[`ChoiceGroup renders ChoiceGroup correctly 1`] = ` top: 8px; } data-automation-id="auto1" - data-is-focusable={true} id="ChoiceGroup0-1" name="ChoiceGroup0" onBlur={[Function]} @@ -584,7 +580,6 @@ exports[`ChoiceGroup renders ChoiceGroup correctly 1`] = ` position: absolute; top: 8px; } - data-is-focusable={false} id="ChoiceGroup0-2" name="ChoiceGroup0" onBlur={[Function]} @@ -698,7 +693,6 @@ exports[`ChoiceGroup renders ChoiceGroup correctly 1`] = ` position: absolute; top: 8px; } - data-is-focusable={false} id="ChoiceGroup0-3" name="ChoiceGroup0" onBlur={[Function]} diff --git a/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap b/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap index 0261c58fd7a9b4..3965b609c29f97 100644 --- a/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap @@ -135,7 +135,6 @@ exports[`HoverCard renders ExpandingCard correctly 1`] = ` "overflowY": "hidden", } } - tabIndex={-1} >
{ return (