From c7c023cc38439c14d8999ae0af167683fd529241 Mon Sep 17 00:00:00 2001 From: David Zearing Date: Thu, 24 Jan 2019 19:01:36 -0800 Subject: [PATCH 1/6] Undoing an old break. --- .../src/components/ChoiceGroup/ChoiceGroup.base.tsx | 6 ------ 1 file changed, 6 deletions(-) diff --git a/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx b/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx index f27c549442098..e68f555aabc77 100644 --- a/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx +++ b/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx @@ -81,11 +81,6 @@ export class ChoiceGroupBase extends BaseComponent !option.disabled); - const keyDefaultFocusable = keyChecked === undefined && firstEnabledOption ? firstEnabledOption.key : undefined; - return (
@@ -100,7 +95,6 @@ export class ChoiceGroupBase extends BaseComponent Date: Thu, 24 Jan 2019 20:30:18 -0800 Subject: [PATCH 2/6] Deleting uselessness. --- .../@uifabric/charting/just_2019-01-10-17-17.json | 11 ----------- .../charting/justified_2019-01-07-06-54.json | 11 ----------- .../@uifabric/charting/start_2019-01-11-20-27.json | 11 ----------- .../charting/starttest_2019-01-08-23-10.json | 11 ----------- .../codepen-example-data_2019-01-22-22-14.json | 11 ----------- .../codepen-example-data_2019-01-22-22-14.json | 11 ----------- .../file-type-icons/changes5_2018-12-03-17-16.json | 11 ----------- .../file-type-icons/just_2019-01-10-17-17.json | 11 ----------- .../file-type-icons/justified_2019-01-07-06-54.json | 11 ----------- .../stackExperiment_2018-12-07-22-48.json | 11 ----------- .../codepen-example-data_2019-01-22-22-14.json | 11 ----------- .../@uifabric/fluent-theme/just_2019-01-10-17-17.json | 11 ----------- .../@uifabric/foundation/just_2019-01-10-17-17.json | 11 ----------- .../foundation/justified_2019-01-07-06-54.json | 11 ----------- .../@uifabric/foundation/start_2019-01-11-20-27.json | 11 ----------- .../foundation/starttest_2019-01-08-23-10.json | 11 ----------- .../@uifabric/icons/changes5_2018-12-03-17-16.json | 11 ----------- .../@uifabric/icons/just_2019-01-10-17-17.json | 11 ----------- .../@uifabric/icons/justified_2019-01-07-06-54.json | 11 ----------- .../icons/stackExperiment_2018-12-07-22-48.json | 11 ----------- .../codepen-example-data_2019-01-22-22-14.json | 11 ----------- .../codepen-example-data_2019-01-22-22-14.json | 11 ----------- .../test-utilities/just_2019-01-10-17-17.json | 11 ----------- .../test-utilities/justified_2019-01-07-06-54.json | 11 ----------- .../test-utilities/pnpm_2018-11-29-05-11.json | 11 ----------- .../test-utilities/start_2019-01-11-20-27.json | 11 ----------- .../test-utilities/starttest_2019-01-08-23-10.json | 11 ----------- .../test-utilities/styled-fix_2018-11-14-05-15.json | 11 ----------- .../codepen-example-data_2019-01-22-22-14.json | 11 ----------- .../@uifabric/utilities/just_2019-01-10-17-17.json | 11 ----------- .../@uifabric/variants/changes5_2018-12-03-17-16.json | 11 ----------- .../codepen-example-data_2019-01-22-22-14.json | 11 ----------- .../@uifabric/variants/just_2019-01-10-17-17.json | 11 ----------- .../variants/justified_2019-01-07-06-54.json | 11 ----------- .../keco-npmignore-images_2018-12-06-23-46.json | 11 ----------- .../variants/stackExperiment_2018-12-07-22-48.json | 11 ----------- .../variants/starttest_2019-01-08-23-10.json | 11 ----------- .../webpack-utils/just-all_2018-12-16-22-03.json | 11 ----------- .../webpack-utils/justified_2019-01-07-06-54.json | 11 ----------- 39 files changed, 429 deletions(-) delete mode 100644 common/changes/@uifabric/charting/just_2019-01-10-17-17.json delete mode 100644 common/changes/@uifabric/charting/justified_2019-01-07-06-54.json delete mode 100644 common/changes/@uifabric/charting/start_2019-01-11-20-27.json delete mode 100644 common/changes/@uifabric/charting/starttest_2019-01-08-23-10.json delete mode 100644 common/changes/@uifabric/example-app-base/codepen-example-data_2019-01-22-22-14.json delete mode 100644 common/changes/@uifabric/fabric-website-resources/codepen-example-data_2019-01-22-22-14.json delete mode 100644 common/changes/@uifabric/file-type-icons/changes5_2018-12-03-17-16.json delete mode 100644 common/changes/@uifabric/file-type-icons/just_2019-01-10-17-17.json delete mode 100644 common/changes/@uifabric/file-type-icons/justified_2019-01-07-06-54.json delete mode 100644 common/changes/@uifabric/file-type-icons/stackExperiment_2018-12-07-22-48.json delete mode 100644 common/changes/@uifabric/fluent-theme/codepen-example-data_2019-01-22-22-14.json delete mode 100644 common/changes/@uifabric/fluent-theme/just_2019-01-10-17-17.json delete mode 100644 common/changes/@uifabric/foundation/just_2019-01-10-17-17.json delete mode 100644 common/changes/@uifabric/foundation/justified_2019-01-07-06-54.json delete mode 100644 common/changes/@uifabric/foundation/start_2019-01-11-20-27.json delete mode 100644 common/changes/@uifabric/foundation/starttest_2019-01-08-23-10.json delete mode 100644 common/changes/@uifabric/icons/changes5_2018-12-03-17-16.json delete mode 100644 common/changes/@uifabric/icons/just_2019-01-10-17-17.json delete mode 100644 common/changes/@uifabric/icons/justified_2019-01-07-06-54.json delete mode 100644 common/changes/@uifabric/icons/stackExperiment_2018-12-07-22-48.json delete mode 100644 common/changes/@uifabric/styling/codepen-example-data_2019-01-22-22-14.json delete mode 100644 common/changes/@uifabric/test-utilities/codepen-example-data_2019-01-22-22-14.json delete mode 100644 common/changes/@uifabric/test-utilities/just_2019-01-10-17-17.json delete mode 100644 common/changes/@uifabric/test-utilities/justified_2019-01-07-06-54.json delete mode 100644 common/changes/@uifabric/test-utilities/pnpm_2018-11-29-05-11.json delete mode 100644 common/changes/@uifabric/test-utilities/start_2019-01-11-20-27.json delete mode 100644 common/changes/@uifabric/test-utilities/starttest_2019-01-08-23-10.json delete mode 100644 common/changes/@uifabric/test-utilities/styled-fix_2018-11-14-05-15.json delete mode 100644 common/changes/@uifabric/theme-samples/codepen-example-data_2019-01-22-22-14.json delete mode 100644 common/changes/@uifabric/utilities/just_2019-01-10-17-17.json delete mode 100644 common/changes/@uifabric/variants/changes5_2018-12-03-17-16.json delete mode 100644 common/changes/@uifabric/variants/codepen-example-data_2019-01-22-22-14.json delete mode 100644 common/changes/@uifabric/variants/just_2019-01-10-17-17.json delete mode 100644 common/changes/@uifabric/variants/justified_2019-01-07-06-54.json delete mode 100644 common/changes/@uifabric/variants/keco-npmignore-images_2018-12-06-23-46.json delete mode 100644 common/changes/@uifabric/variants/stackExperiment_2018-12-07-22-48.json delete mode 100644 common/changes/@uifabric/variants/starttest_2019-01-08-23-10.json delete mode 100644 common/changes/@uifabric/webpack-utils/just-all_2018-12-16-22-03.json delete mode 100644 common/changes/@uifabric/webpack-utils/justified_2019-01-07-06-54.json diff --git a/common/changes/@uifabric/charting/just_2019-01-10-17-17.json b/common/changes/@uifabric/charting/just_2019-01-10-17-17.json deleted file mode 100644 index 22f7bf4536e70..0000000000000 --- a/common/changes/@uifabric/charting/just_2019-01-10-17-17.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/charting", - "type": "none" - } - ], - "packageName": "@uifabric/charting", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/charting/justified_2019-01-07-06-54.json b/common/changes/@uifabric/charting/justified_2019-01-07-06-54.json deleted file mode 100644 index 22f7bf4536e70..0000000000000 --- a/common/changes/@uifabric/charting/justified_2019-01-07-06-54.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/charting", - "type": "none" - } - ], - "packageName": "@uifabric/charting", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/charting/start_2019-01-11-20-27.json b/common/changes/@uifabric/charting/start_2019-01-11-20-27.json deleted file mode 100644 index 22f7bf4536e70..0000000000000 --- a/common/changes/@uifabric/charting/start_2019-01-11-20-27.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/charting", - "type": "none" - } - ], - "packageName": "@uifabric/charting", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/charting/starttest_2019-01-08-23-10.json b/common/changes/@uifabric/charting/starttest_2019-01-08-23-10.json deleted file mode 100644 index 22f7bf4536e70..0000000000000 --- a/common/changes/@uifabric/charting/starttest_2019-01-08-23-10.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/charting", - "type": "none" - } - ], - "packageName": "@uifabric/charting", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/example-app-base/codepen-example-data_2019-01-22-22-14.json b/common/changes/@uifabric/example-app-base/codepen-example-data_2019-01-22-22-14.json deleted file mode 100644 index fff83c7d7d632..0000000000000 --- a/common/changes/@uifabric/example-app-base/codepen-example-data_2019-01-22-22-14.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/example-app-base", - "type": "none" - } - ], - "packageName": "@uifabric/example-app-base", - "email": "elcraig@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/fabric-website-resources/codepen-example-data_2019-01-22-22-14.json b/common/changes/@uifabric/fabric-website-resources/codepen-example-data_2019-01-22-22-14.json deleted file mode 100644 index c02296ff0e2b5..0000000000000 --- a/common/changes/@uifabric/fabric-website-resources/codepen-example-data_2019-01-22-22-14.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/fabric-website-resources", - "type": "none" - } - ], - "packageName": "@uifabric/fabric-website-resources", - "email": "elcraig@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/file-type-icons/changes5_2018-12-03-17-16.json b/common/changes/@uifabric/file-type-icons/changes5_2018-12-03-17-16.json deleted file mode 100644 index 3d5520b6a2558..0000000000000 --- a/common/changes/@uifabric/file-type-icons/changes5_2018-12-03-17-16.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/file-type-icons", - "type": "none" - } - ], - "packageName": "@uifabric/file-type-icons", - "email": "Humberto.Morimoto@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/file-type-icons/just_2019-01-10-17-17.json b/common/changes/@uifabric/file-type-icons/just_2019-01-10-17-17.json deleted file mode 100644 index 4f0663f9220a5..0000000000000 --- a/common/changes/@uifabric/file-type-icons/just_2019-01-10-17-17.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/file-type-icons", - "type": "none" - } - ], - "packageName": "@uifabric/file-type-icons", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/file-type-icons/justified_2019-01-07-06-54.json b/common/changes/@uifabric/file-type-icons/justified_2019-01-07-06-54.json deleted file mode 100644 index 4f0663f9220a5..0000000000000 --- a/common/changes/@uifabric/file-type-icons/justified_2019-01-07-06-54.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/file-type-icons", - "type": "none" - } - ], - "packageName": "@uifabric/file-type-icons", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/file-type-icons/stackExperiment_2018-12-07-22-48.json b/common/changes/@uifabric/file-type-icons/stackExperiment_2018-12-07-22-48.json deleted file mode 100644 index 3d5520b6a2558..0000000000000 --- a/common/changes/@uifabric/file-type-icons/stackExperiment_2018-12-07-22-48.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/file-type-icons", - "type": "none" - } - ], - "packageName": "@uifabric/file-type-icons", - "email": "Humberto.Morimoto@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/fluent-theme/codepen-example-data_2019-01-22-22-14.json b/common/changes/@uifabric/fluent-theme/codepen-example-data_2019-01-22-22-14.json deleted file mode 100644 index 7c6637bc061b6..0000000000000 --- a/common/changes/@uifabric/fluent-theme/codepen-example-data_2019-01-22-22-14.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/fluent-theme", - "type": "none" - } - ], - "packageName": "@uifabric/fluent-theme", - "email": "elcraig@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/fluent-theme/just_2019-01-10-17-17.json b/common/changes/@uifabric/fluent-theme/just_2019-01-10-17-17.json deleted file mode 100644 index 85972c9122ef0..0000000000000 --- a/common/changes/@uifabric/fluent-theme/just_2019-01-10-17-17.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/fluent-theme", - "type": "none" - } - ], - "packageName": "@uifabric/fluent-theme", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/foundation/just_2019-01-10-17-17.json b/common/changes/@uifabric/foundation/just_2019-01-10-17-17.json deleted file mode 100644 index fb961d42c3038..0000000000000 --- a/common/changes/@uifabric/foundation/just_2019-01-10-17-17.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/foundation", - "type": "none" - } - ], - "packageName": "@uifabric/foundation", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/foundation/justified_2019-01-07-06-54.json b/common/changes/@uifabric/foundation/justified_2019-01-07-06-54.json deleted file mode 100644 index fb961d42c3038..0000000000000 --- a/common/changes/@uifabric/foundation/justified_2019-01-07-06-54.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/foundation", - "type": "none" - } - ], - "packageName": "@uifabric/foundation", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/foundation/start_2019-01-11-20-27.json b/common/changes/@uifabric/foundation/start_2019-01-11-20-27.json deleted file mode 100644 index fb961d42c3038..0000000000000 --- a/common/changes/@uifabric/foundation/start_2019-01-11-20-27.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/foundation", - "type": "none" - } - ], - "packageName": "@uifabric/foundation", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/foundation/starttest_2019-01-08-23-10.json b/common/changes/@uifabric/foundation/starttest_2019-01-08-23-10.json deleted file mode 100644 index fb961d42c3038..0000000000000 --- a/common/changes/@uifabric/foundation/starttest_2019-01-08-23-10.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/foundation", - "type": "none" - } - ], - "packageName": "@uifabric/foundation", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/icons/changes5_2018-12-03-17-16.json b/common/changes/@uifabric/icons/changes5_2018-12-03-17-16.json deleted file mode 100644 index 273841cb5b963..0000000000000 --- a/common/changes/@uifabric/icons/changes5_2018-12-03-17-16.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/icons", - "type": "none" - } - ], - "packageName": "@uifabric/icons", - "email": "Humberto.Morimoto@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/icons/just_2019-01-10-17-17.json b/common/changes/@uifabric/icons/just_2019-01-10-17-17.json deleted file mode 100644 index ec5c606691c78..0000000000000 --- a/common/changes/@uifabric/icons/just_2019-01-10-17-17.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/icons", - "type": "none" - } - ], - "packageName": "@uifabric/icons", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/icons/justified_2019-01-07-06-54.json b/common/changes/@uifabric/icons/justified_2019-01-07-06-54.json deleted file mode 100644 index ec5c606691c78..0000000000000 --- a/common/changes/@uifabric/icons/justified_2019-01-07-06-54.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/icons", - "type": "none" - } - ], - "packageName": "@uifabric/icons", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/icons/stackExperiment_2018-12-07-22-48.json b/common/changes/@uifabric/icons/stackExperiment_2018-12-07-22-48.json deleted file mode 100644 index 273841cb5b963..0000000000000 --- a/common/changes/@uifabric/icons/stackExperiment_2018-12-07-22-48.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/icons", - "type": "none" - } - ], - "packageName": "@uifabric/icons", - "email": "Humberto.Morimoto@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/styling/codepen-example-data_2019-01-22-22-14.json b/common/changes/@uifabric/styling/codepen-example-data_2019-01-22-22-14.json deleted file mode 100644 index 495be6e7c088a..0000000000000 --- a/common/changes/@uifabric/styling/codepen-example-data_2019-01-22-22-14.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/styling", - "type": "none" - } - ], - "packageName": "@uifabric/styling", - "email": "elcraig@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/test-utilities/codepen-example-data_2019-01-22-22-14.json b/common/changes/@uifabric/test-utilities/codepen-example-data_2019-01-22-22-14.json deleted file mode 100644 index da748c4a9b90b..0000000000000 --- a/common/changes/@uifabric/test-utilities/codepen-example-data_2019-01-22-22-14.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/test-utilities", - "type": "none" - } - ], - "packageName": "@uifabric/test-utilities", - "email": "elcraig@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/test-utilities/just_2019-01-10-17-17.json b/common/changes/@uifabric/test-utilities/just_2019-01-10-17-17.json deleted file mode 100644 index 389565beb153d..0000000000000 --- a/common/changes/@uifabric/test-utilities/just_2019-01-10-17-17.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/test-utilities", - "type": "none" - } - ], - "packageName": "@uifabric/test-utilities", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/test-utilities/justified_2019-01-07-06-54.json b/common/changes/@uifabric/test-utilities/justified_2019-01-07-06-54.json deleted file mode 100644 index 389565beb153d..0000000000000 --- a/common/changes/@uifabric/test-utilities/justified_2019-01-07-06-54.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/test-utilities", - "type": "none" - } - ], - "packageName": "@uifabric/test-utilities", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/test-utilities/pnpm_2018-11-29-05-11.json b/common/changes/@uifabric/test-utilities/pnpm_2018-11-29-05-11.json deleted file mode 100644 index da748c4a9b90b..0000000000000 --- a/common/changes/@uifabric/test-utilities/pnpm_2018-11-29-05-11.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/test-utilities", - "type": "none" - } - ], - "packageName": "@uifabric/test-utilities", - "email": "elcraig@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/test-utilities/start_2019-01-11-20-27.json b/common/changes/@uifabric/test-utilities/start_2019-01-11-20-27.json deleted file mode 100644 index 389565beb153d..0000000000000 --- a/common/changes/@uifabric/test-utilities/start_2019-01-11-20-27.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/test-utilities", - "type": "none" - } - ], - "packageName": "@uifabric/test-utilities", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/test-utilities/starttest_2019-01-08-23-10.json b/common/changes/@uifabric/test-utilities/starttest_2019-01-08-23-10.json deleted file mode 100644 index 389565beb153d..0000000000000 --- a/common/changes/@uifabric/test-utilities/starttest_2019-01-08-23-10.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/test-utilities", - "type": "none" - } - ], - "packageName": "@uifabric/test-utilities", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/test-utilities/styled-fix_2018-11-14-05-15.json b/common/changes/@uifabric/test-utilities/styled-fix_2018-11-14-05-15.json deleted file mode 100644 index 2d7aff2196a87..0000000000000 --- a/common/changes/@uifabric/test-utilities/styled-fix_2018-11-14-05-15.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/test-utilities", - "type": "none" - } - ], - "packageName": "@uifabric/test-utilities", - "email": "dzearing@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/theme-samples/codepen-example-data_2019-01-22-22-14.json b/common/changes/@uifabric/theme-samples/codepen-example-data_2019-01-22-22-14.json deleted file mode 100644 index 76b2552a14f31..0000000000000 --- a/common/changes/@uifabric/theme-samples/codepen-example-data_2019-01-22-22-14.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/theme-samples", - "type": "none" - } - ], - "packageName": "@uifabric/theme-samples", - "email": "elcraig@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/utilities/just_2019-01-10-17-17.json b/common/changes/@uifabric/utilities/just_2019-01-10-17-17.json deleted file mode 100644 index e1da569867d9e..0000000000000 --- a/common/changes/@uifabric/utilities/just_2019-01-10-17-17.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/utilities", - "type": "none" - } - ], - "packageName": "@uifabric/utilities", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/variants/changes5_2018-12-03-17-16.json b/common/changes/@uifabric/variants/changes5_2018-12-03-17-16.json deleted file mode 100644 index b8074b9f27c04..0000000000000 --- a/common/changes/@uifabric/variants/changes5_2018-12-03-17-16.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/variants", - "type": "none" - } - ], - "packageName": "@uifabric/variants", - "email": "Humberto.Morimoto@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/variants/codepen-example-data_2019-01-22-22-14.json b/common/changes/@uifabric/variants/codepen-example-data_2019-01-22-22-14.json deleted file mode 100644 index 4db7f1fea1795..0000000000000 --- a/common/changes/@uifabric/variants/codepen-example-data_2019-01-22-22-14.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/variants", - "type": "none" - } - ], - "packageName": "@uifabric/variants", - "email": "elcraig@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/variants/just_2019-01-10-17-17.json b/common/changes/@uifabric/variants/just_2019-01-10-17-17.json deleted file mode 100644 index 1ca8b3ed20f51..0000000000000 --- a/common/changes/@uifabric/variants/just_2019-01-10-17-17.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/variants", - "type": "none" - } - ], - "packageName": "@uifabric/variants", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/variants/justified_2019-01-07-06-54.json b/common/changes/@uifabric/variants/justified_2019-01-07-06-54.json deleted file mode 100644 index 1ca8b3ed20f51..0000000000000 --- a/common/changes/@uifabric/variants/justified_2019-01-07-06-54.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/variants", - "type": "none" - } - ], - "packageName": "@uifabric/variants", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/variants/keco-npmignore-images_2018-12-06-23-46.json b/common/changes/@uifabric/variants/keco-npmignore-images_2018-12-06-23-46.json deleted file mode 100644 index e69884c9b2ee6..0000000000000 --- a/common/changes/@uifabric/variants/keco-npmignore-images_2018-12-06-23-46.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "packageName": "@uifabric/variants", - "comment": "Add image file types to .npmignore.", - "type": "none" - } - ], - "packageName": "@uifabric/variants", - "email": "keco@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/variants/stackExperiment_2018-12-07-22-48.json b/common/changes/@uifabric/variants/stackExperiment_2018-12-07-22-48.json deleted file mode 100644 index b8074b9f27c04..0000000000000 --- a/common/changes/@uifabric/variants/stackExperiment_2018-12-07-22-48.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/variants", - "type": "none" - } - ], - "packageName": "@uifabric/variants", - "email": "Humberto.Morimoto@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/variants/starttest_2019-01-08-23-10.json b/common/changes/@uifabric/variants/starttest_2019-01-08-23-10.json deleted file mode 100644 index 1ca8b3ed20f51..0000000000000 --- a/common/changes/@uifabric/variants/starttest_2019-01-08-23-10.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/variants", - "type": "none" - } - ], - "packageName": "@uifabric/variants", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/webpack-utils/just-all_2018-12-16-22-03.json b/common/changes/@uifabric/webpack-utils/just-all_2018-12-16-22-03.json deleted file mode 100644 index 4ac083be11b64..0000000000000 --- a/common/changes/@uifabric/webpack-utils/just-all_2018-12-16-22-03.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/webpack-utils", - "type": "none" - } - ], - "packageName": "@uifabric/webpack-utils", - "email": "kchau@microsoft.com" -} \ No newline at end of file diff --git a/common/changes/@uifabric/webpack-utils/justified_2019-01-07-06-54.json b/common/changes/@uifabric/webpack-utils/justified_2019-01-07-06-54.json deleted file mode 100644 index 4ac083be11b64..0000000000000 --- a/common/changes/@uifabric/webpack-utils/justified_2019-01-07-06-54.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "comment": "", - "packageName": "@uifabric/webpack-utils", - "type": "none" - } - ], - "packageName": "@uifabric/webpack-utils", - "email": "kchau@microsoft.com" -} \ No newline at end of file From 64b670a128f67197ba1d9d6102d4af576513a485 Mon Sep 17 00:00:00 2001 From: David Zearing Date: Thu, 24 Jan 2019 20:32:13 -0800 Subject: [PATCH 3/6] Adding change file. --- .../choicegroup-fix_2019-01-25-04-32.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/office-ui-fabric-react/choicegroup-fix_2019-01-25-04-32.json diff --git a/common/changes/office-ui-fabric-react/choicegroup-fix_2019-01-25-04-32.json b/common/changes/office-ui-fabric-react/choicegroup-fix_2019-01-25-04-32.json new file mode 100644 index 0000000000000..2faaf5c586860 --- /dev/null +++ b/common/changes/office-ui-fabric-react/choicegroup-fix_2019-01-25-04-32.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "ChoiceGroup: fixing issue when nested in FocusZones.", + "type": "patch" + } + ], + "packageName": "office-ui-fabric-react", + "email": "dzearing@microsoft.com" +} \ No newline at end of file From a6483fcf545071879374bb6919d6d4dd37be6f4d Mon Sep 17 00:00:00 2001 From: David Zearing Date: Wed, 20 Feb 2019 11:57:14 -0800 Subject: [PATCH 4/6] Removing popup -1 and choicegroup data-is-focsuable fixes, which are both causing regressions. --- .../src/components/ChoiceGroup/ChoiceGroup.base.tsx | 2 +- packages/office-ui-fabric-react/src/components/Popup/Popup.tsx | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx b/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx index f27c549442098..9b6aaa7b312e0 100644 --- a/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx +++ b/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx @@ -100,7 +100,7 @@ export class ChoiceGroupBase extends BaseComponent { return (
Date: Wed, 20 Feb 2019 12:00:16 -0800 Subject: [PATCH 5/6] change file --- .../choicegroup-fix_2019-02-20-20-00.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/office-ui-fabric-react/choicegroup-fix_2019-02-20-20-00.json diff --git a/common/changes/office-ui-fabric-react/choicegroup-fix_2019-02-20-20-00.json b/common/changes/office-ui-fabric-react/choicegroup-fix_2019-02-20-20-00.json new file mode 100644 index 0000000000000..cbcc213a8fd6e --- /dev/null +++ b/common/changes/office-ui-fabric-react/choicegroup-fix_2019-02-20-20-00.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "ChoiceGroup: now works again in FocusZone, but this also reverts a bug fix which allowed FocusTrapZones to behave better with ChoiceGroups in them. We will fix this issue separately. Popup: no longer has `tabindex=\"-1\"` specified, which is causing all sorts of regressions wrt FocusTrapZone usage.", + "type": "minor" + } + ], + "packageName": "office-ui-fabric-react", + "email": "dzearing@microsoft.com" +} \ No newline at end of file From cff936b2324f2b1ec1d2947cb2532b0c50d458ba Mon Sep 17 00:00:00 2001 From: David Zearing Date: Wed, 20 Feb 2019 12:42:26 -0800 Subject: [PATCH 6/6] snapshots --- .../__snapshots__/Callout.test.tsx.snap | 1 - .../ChoiceGroup/ChoiceGroup.test.tsx | 24 ------------------- .../__snapshots__/ChoiceGroup.test.tsx.snap | 6 ----- .../__snapshots__/HoverCard.test.tsx.snap | 2 -- .../Modal/__snapshots__/Modal.test.tsx.snap | 1 - .../Panel/__snapshots__/Panel.test.tsx.snap | 1 - .../TeachingBubble.test.tsx.snap | 1 - .../__snapshots__/Tooltip.test.tsx.snap | 1 - .../Callout.Basic.Example.tsx.shot | 1 - .../ChoiceGroup.Basic.Example.tsx.shot | 4 ---- .../ChoiceGroup.Custom.Example.tsx.shot | 4 ---- .../ChoiceGroup.Icon.Example.tsx.shot | 3 --- .../ChoiceGroup.Image.Example.tsx.shot | 2 -- .../ChoiceGroup.Label.Example.tsx.shot | 4 ---- .../ContextualMenu.Persisted.Example.tsx.shot | 1 - .../Panel.HiddenOnDismiss.Example.tsx.shot | 1 - .../Pivot.Fabric.Example.tsx.shot | 1 - 17 files changed, 58 deletions(-) diff --git a/packages/office-ui-fabric-react/src/components/Callout/__snapshots__/Callout.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Callout/__snapshots__/Callout.test.tsx.snap index 721a0b64af6bd..8750c19fb9834 100644 --- a/packages/office-ui-fabric-react/src/components/Callout/__snapshots__/Callout.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Callout/__snapshots__/Callout.test.tsx.snap @@ -58,7 +58,6 @@ exports[`Callout renders Callout correctly 1`] = ` "overflowY": undefined, } } - tabIndex={-1} > Content
diff --git a/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.test.tsx b/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.test.tsx index 3f35be3b5de40..c8c2b6bd77cb4 100644 --- a/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.test.tsx +++ b/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.test.tsx @@ -44,36 +44,24 @@ describe('ChoiceGroup', () => { expect((choiceOptions[0] as HTMLInputElement).checked).toEqual(false); expect((choiceOptions[1] as HTMLInputElement).checked).toEqual(false); expect((choiceOptions[2] as HTMLInputElement).checked).toEqual(false); - expect((choiceOptions[0] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('true'); - expect((choiceOptions[1] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); - expect((choiceOptions[2] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); ReactTestUtils.Simulate.change(choiceOptions[0]); expect((choiceOptions[0] as HTMLInputElement).checked).toEqual(true); expect((choiceOptions[1] as HTMLInputElement).checked).toEqual(false); expect((choiceOptions[2] as HTMLInputElement).checked).toEqual(false); - expect((choiceOptions[0] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('true'); - expect((choiceOptions[1] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); - expect((choiceOptions[2] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); ReactTestUtils.Simulate.change(choiceOptions[1]); expect((choiceOptions[0] as HTMLInputElement).checked).toEqual(false); expect((choiceOptions[1] as HTMLInputElement).checked).toEqual(true); expect((choiceOptions[2] as HTMLInputElement).checked).toEqual(false); - expect((choiceOptions[0] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); - expect((choiceOptions[1] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('true'); - expect((choiceOptions[2] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); ReactTestUtils.Simulate.change(choiceOptions[0]); expect((choiceOptions[0] as HTMLInputElement).checked).toEqual(true); expect((choiceOptions[1] as HTMLInputElement).checked).toEqual(false); expect((choiceOptions[2] as HTMLInputElement).checked).toEqual(false); - expect((choiceOptions[0] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('true'); - expect((choiceOptions[1] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); - expect((choiceOptions[2] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); }); it('An individual choice option can be disabled', () => { @@ -87,9 +75,6 @@ describe('ChoiceGroup', () => { expect((choiceOptions[0] as HTMLInputElement).disabled).toEqual(true); expect((choiceOptions[1] as HTMLInputElement).disabled).toEqual(false); expect((choiceOptions[2] as HTMLInputElement).disabled).toEqual(false); - expect((choiceOptions[0] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); - expect((choiceOptions[1] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('true'); - expect((choiceOptions[2] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); }); it('renders all choice options as disabled when disabled', () => { @@ -100,9 +85,6 @@ describe('ChoiceGroup', () => { expect((choiceOptions[0] as HTMLInputElement).disabled).toEqual(true); expect((choiceOptions[1] as HTMLInputElement).disabled).toEqual(true); expect((choiceOptions[2] as HTMLInputElement).disabled).toEqual(true); - expect((choiceOptions[0] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); - expect((choiceOptions[1] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); - expect((choiceOptions[2] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('false'); }); it('can act as an uncontrolled component', () => { @@ -192,10 +174,4 @@ describe('ChoiceGroup', () => { expect(choiceGroupRef.current!.checkedOption).toBeDefined(); expect(choiceGroupRef.current!.checkedOption).toEqual(TEST_OPTIONS[0]); }); - - it('sets the first enabled option to focusable, even with an invalid defaultSelectedKey', () => { - const choiceGroup = mount(); - const choiceOptions = choiceGroup.getDOMNode().querySelectorAll(QUERY_SELECTOR); - expect((choiceOptions[0] as HTMLInputElement).getAttribute('data-is-focusable')).toEqual('true'); - }); }); diff --git a/packages/office-ui-fabric-react/src/components/ChoiceGroup/__snapshots__/ChoiceGroup.test.tsx.snap b/packages/office-ui-fabric-react/src/components/ChoiceGroup/__snapshots__/ChoiceGroup.test.tsx.snap index 20494efd1e6e9..f865a189cd530 100644 --- a/packages/office-ui-fabric-react/src/components/ChoiceGroup/__snapshots__/ChoiceGroup.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/ChoiceGroup/__snapshots__/ChoiceGroup.test.tsx.snap @@ -98,7 +98,6 @@ exports[`ChoiceGroup label does not have className prop from parent 1`] = ` top: 8px; } data-automation-id="auto1" - data-is-focusable={true} id="ChoiceGroup0-1" name="ChoiceGroup0" onBlur={[Function]} @@ -212,7 +211,6 @@ exports[`ChoiceGroup label does not have className prop from parent 1`] = ` position: absolute; top: 8px; } - data-is-focusable={false} id="ChoiceGroup0-2" name="ChoiceGroup0" onBlur={[Function]} @@ -326,7 +324,6 @@ exports[`ChoiceGroup label does not have className prop from parent 1`] = ` position: absolute; top: 8px; } - data-is-focusable={false} id="ChoiceGroup0-3" name="ChoiceGroup0" onBlur={[Function]} @@ -470,7 +467,6 @@ exports[`ChoiceGroup renders ChoiceGroup correctly 1`] = ` top: 8px; } data-automation-id="auto1" - data-is-focusable={true} id="ChoiceGroup0-1" name="ChoiceGroup0" onBlur={[Function]} @@ -584,7 +580,6 @@ exports[`ChoiceGroup renders ChoiceGroup correctly 1`] = ` position: absolute; top: 8px; } - data-is-focusable={false} id="ChoiceGroup0-2" name="ChoiceGroup0" onBlur={[Function]} @@ -698,7 +693,6 @@ exports[`ChoiceGroup renders ChoiceGroup correctly 1`] = ` position: absolute; top: 8px; } - data-is-focusable={false} id="ChoiceGroup0-3" name="ChoiceGroup0" onBlur={[Function]} diff --git a/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap b/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap index 0261c58fd7a9b..3965b609c29f9 100644 --- a/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap @@ -135,7 +135,6 @@ exports[`HoverCard renders ExpandingCard correctly 1`] = ` "overflowY": "hidden", } } - tabIndex={-1} >