Change OnPropertyChangeStrings to use nameof (#1374)

mjbvz · web-flow · commit f32bf44b6674 · 2016-10-20T17:40:11.000-07:00
**Bug**
Most of our calls to `OnPropertyChange` currently use string values. This is problematic because strings are not strongly typed, so they can easily get out of sync with the actual property names.

**Fix**
Change these calls to use `nameof` instead. This ensures that an error is produced if the names ever get out of sync. Also this makes c# refactorings do the correct thing.
diff --git a/Nodejs/Product/Nodejs/NpmUI/LastRefreshedMessageProvider.cs b/Nodejs/Product/Nodejs/NpmUI/LastRefreshedMessageProvider.cs
@@ -65,8 +65,5 @@ public LastRefreshedMessageProvider(DateTime lastRefreshTime) {
         public int Days { get; private set; }
 
         public string Description { get; private set; }
-
-        public bool IsOld { get { return Days > 7; } }
-        public bool IsAncient { get { return Days > 14; } }
     }
 }
diff --git a/Nodejs/Product/Nodejs/NpmUI/NpmOutputViewModel.cs b/Nodejs/Product/Nodejs/NpmUI/NpmOutputViewModel.cs
@@ -99,9 +99,9 @@ public bool IsExecutingCommand {
                     Pulse();
                 }
                 OnPropertyChanged();
-                OnPropertyChanged("ExecutionProgressVisibility");
-                OnPropertyChanged("ExecutionIdleVisibility");
-                OnPropertyChanged("IsCancellable");
+                OnPropertyChanged(nameof(ExecutionProgressVisibility));
+                OnPropertyChanged(nameof(ExecutionIdleVisibility));
+                OnPropertyChanged(nameof(IsCancellable));
             }
         }
 
@@ -148,7 +148,7 @@ public void Cancel() {
             }
 
             UpdateStatusMessage();
-            OnPropertyChanged("IsCancellable");
+            OnPropertyChanged(nameof(IsCancellable));
         }
 
         private void QueueCommand(QueuedNpmCommandInfo info) {
@@ -162,7 +162,7 @@ private void QueueCommand(QueuedNpmCommandInfo info) {
             }
 
             UpdateStatusMessageSafe();
-            OnPropertyChanged("IsCancellable");
+            OnPropertyChanged(nameof(IsCancellable));
         }
 
         public void QueueCommand(string arguments) {
@@ -217,7 +217,7 @@ await cmdr.InstallPackageByVersionAsync(
 
         private void HandleCompletionSafe() {
             UpdateStatusMessage();
-            OnPropertyChanged("IsCancellable");
+            OnPropertyChanged(nameof(IsCancellable));
         }
 
         private void commander_CommandCompleted(object sender, NpmCommandCompletedEventArgs e) {
diff --git a/Nodejs/Product/Nodejs/NpmUI/NpmPackageInstallViewModel.cs b/Nodejs/Product/Nodejs/NpmUI/NpmPackageInstallViewModel.cs
@@ -118,7 +118,7 @@ public bool IsLoadingCatalog {
             private set {
                 _isLoadingCatalog = value;
                 OnPropertyChanged();
-                OnPropertyChanged("CanRefreshCatalog");
+                OnPropertyChanged(nameof(CanRefreshCatalog));
             }
         }
 
@@ -155,7 +155,7 @@ public Visibility LoadingCatalogControlVisibility {
             set {
                 _loadingCatalogControlVisibility = value;
                 OnPropertyChanged();
-                OnPropertyChanged("FilterControlsVisibility");
+                OnPropertyChanged(nameof(FilterControlsVisibility));
             }
         }
         
@@ -258,7 +258,7 @@ private bool IsFiltering {
             set {
                 _isFiltering = value;
                 OnPropertyChanged();
-                OnPropertyChanged("PackageFilterState");
+                OnPropertyChanged(nameof(PackageFilterState));
             }
         }
 
@@ -276,7 +276,7 @@ public IList<PackageCatalogEntryViewModel> FilteredPackages {
                 // PackageFilterState should be triggered before FilteredPackages
                 // to allow the UI to update the status before the package list,
                 // making for a smoother experience.
-                OnPropertyChanged("PackageFilterState");
+                OnPropertyChanged(nameof(PackageFilterState));
                 OnPropertyChanged();
             }
         }
@@ -290,7 +290,7 @@ public string FilterText {
                 IsFiltering = !string.IsNullOrWhiteSpace(_filterText);
 
                 OnPropertyChanged();
-                OnPropertyChanged("PackageFilterState");
+                OnPropertyChanged(nameof(PackageFilterState));
             }
         }
 
diff --git a/Nodejs/Product/Profiling/Profiling/CompareReportsView.cs b/Nodejs/Product/Profiling/Profiling/CompareReportsView.cs
@@ -80,7 +80,7 @@ public string BaselineFile {
             set {
                 if (_baselineFile != value) {
                     _baselineFile = value;
-                    OnPropertyChanged("BaselineFile");
+                    OnPropertyChanged(nameof(BaselineFile));
                 }
             }
         }
@@ -95,7 +95,7 @@ public string ComparisonFile {
             set {
                 if (_comparisonFile != value) {
                     _comparisonFile = value;
-                    OnPropertyChanged("ComparisonFile");
+                    OnPropertyChanged(nameof(ComparisonFile));
                 }
             }
         }
@@ -119,7 +119,7 @@ public bool IsValid {
             private set {
                 if (_isValid != value) {
                     _isValid = value;
-                    OnPropertyChanged("IsValid");
+                    OnPropertyChanged(nameof(IsValid));
                 }
             }
         }
diff --git a/Nodejs/Product/Profiling/Profiling/ProfilingTargetView.cs b/Nodejs/Product/Profiling/Profiling/ProfilingTargetView.cs
@@ -127,7 +127,7 @@ public ProjectTargetView Project {
             set {
                 if (_project != value) {
                     _project = value;
-                    OnPropertyChanged("Project");
+                    OnPropertyChanged(nameof(Project));
                 }
             }
         }
@@ -142,7 +142,7 @@ public bool IsProjectSelected {
             set {
                 if (_isProjectSelected != value) {
                     _isProjectSelected = value;
-                    OnPropertyChanged("IsProjectSelected");
+                    OnPropertyChanged(nameof(IsProjectSelected));
                 }
             }
         }
@@ -164,7 +164,7 @@ public StandaloneTargetView Standalone {
                         _standalone.PropertyChanged += Standalone_PropertyChanged;
                     }
 
-                    OnPropertyChanged("Standalone");
+                    OnPropertyChanged(nameof(Standalone));
                 }
             }
         }
@@ -179,7 +179,7 @@ public bool IsStandaloneSelected {
             set {
                 if (_isStandaloneSelected != value) {
                     _isStandaloneSelected = value;
-                    OnPropertyChanged("IsStandaloneSelected");
+                    OnPropertyChanged(nameof(IsStandaloneSelected));
                 }
             }
         }
@@ -204,7 +204,7 @@ void ProfilingTargetView_PropertyChanged(object sender, PropertyChangedEventArgs
         /// </summary>
         private void Standalone_PropertyChanged(object sender, PropertyChangedEventArgs e) {
             Debug.Assert(Standalone == sender);
-            OnPropertyChanged("Standalone");
+            OnPropertyChanged(nameof(Standalone));
         }
 
 
@@ -218,7 +218,7 @@ public bool IsValid {
             private set {
                 if (_isValid != value) {
                     _isValid = value;
-                    OnPropertyChanged("IsValid");
+                    OnPropertyChanged(nameof(IsValid));
                 }
             }
         }
diff --git a/Nodejs/Product/Profiling/Profiling/StandaloneTargetView.cs b/Nodejs/Product/Profiling/Profiling/StandaloneTargetView.cs
@@ -85,7 +85,7 @@ public string InterpreterPath {
             set {
                 if (_interpreterPath != value) {
                     _interpreterPath = value;
-                    OnPropertyChanged("InterpreterPath");
+                    OnPropertyChanged(nameof(InterpreterPath));
                 }
             }
         }
@@ -100,7 +100,7 @@ public string ScriptPath {
             set {
                 if (_scriptPath != value) {
                     _scriptPath = value;
-                    OnPropertyChanged("ScriptPath");
+                    OnPropertyChanged(nameof(ScriptPath));
                     //if (string.IsNullOrEmpty(WorkingDirectory)) {
                     //    WorkingDirectory = Path.GetDirectoryName(_scriptPath);
                     //}
@@ -118,7 +118,7 @@ public string WorkingDirectory {
             set {
                 if (_workingDirectory != value) {
                     _workingDirectory = value;
-                    OnPropertyChanged("WorkingDirectory");
+                    OnPropertyChanged(nameof(WorkingDirectory));
                 }
             }
         }
@@ -133,7 +133,7 @@ public string Arguments {
             set {
                 if (_arguments != value) {
                     _arguments = value;
-                    OnPropertyChanged("Arguments");
+                    OnPropertyChanged(nameof(Arguments));
                 }
             }
         }
@@ -164,7 +164,7 @@ public bool IsValid {
             private set {
                 if (_isValid != value) {
                     _isValid = value;
-                    OnPropertyChanged("IsValid");
+                    OnPropertyChanged(nameof(IsValid));
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,5 @@ public LastRefreshedMessageProvider(DateTime lastRefreshTime) {`
`65`	`65`	`public int Days { get; private set; }`
`66`	`66`
`67`	`67`	`public string Description { get; private set; }`
`68`		`-`
`69`		`- public bool IsOld { get { return Days > 7; } }`
`70`		`- public bool IsAncient { get { return Days > 14; } }`
`71`	`68`	`}`
`72`	`69`	`}`
Original file line number	Diff line number	Diff line change
`@@ -99,9 +99,9 @@ public bool IsExecutingCommand {`
`99`	`99`	`Pulse();`
`100`	`100`	`}`
`101`	`101`	`OnPropertyChanged();`
`102`		`- OnPropertyChanged("ExecutionProgressVisibility");`
`103`		`- OnPropertyChanged("ExecutionIdleVisibility");`
`104`		`- OnPropertyChanged("IsCancellable");`
	`102`	`+ OnPropertyChanged(nameof(ExecutionProgressVisibility));`
	`103`	`+ OnPropertyChanged(nameof(ExecutionIdleVisibility));`
	`104`	`+ OnPropertyChanged(nameof(IsCancellable));`
`105`	`105`	`}`
`106`	`106`	`}`
`107`	`107`
`@@ -148,7 +148,7 @@ public void Cancel() {`
`148`	`148`	`}`
`149`	`149`
`150`	`150`	`UpdateStatusMessage();`
`151`		`- OnPropertyChanged("IsCancellable");`
	`151`	`+ OnPropertyChanged(nameof(IsCancellable));`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`private void QueueCommand(QueuedNpmCommandInfo info) {`
`@@ -162,7 +162,7 @@ private void QueueCommand(QueuedNpmCommandInfo info) {`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`UpdateStatusMessageSafe();`
`165`		`- OnPropertyChanged("IsCancellable");`
	`165`	`+ OnPropertyChanged(nameof(IsCancellable));`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`public void QueueCommand(string arguments) {`
`@@ -217,7 +217,7 @@ await cmdr.InstallPackageByVersionAsync(`
`217`	`217`
`218`	`218`	`private void HandleCompletionSafe() {`
`219`	`219`	`UpdateStatusMessage();`
`220`		`- OnPropertyChanged("IsCancellable");`
	`220`	`+ OnPropertyChanged(nameof(IsCancellable));`
`221`	`221`	`}`
`222`	`222`
`223`	`223`	`private void commander_CommandCompleted(object sender, NpmCommandCompletedEventArgs e) {`
Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ public bool IsLoadingCatalog {`
`118`	`118`	`private set {`
`119`	`119`	`_isLoadingCatalog = value;`
`120`	`120`	`OnPropertyChanged();`
`121`		`- OnPropertyChanged("CanRefreshCatalog");`
	`121`	`+ OnPropertyChanged(nameof(CanRefreshCatalog));`
`122`	`122`	`}`
`123`	`123`	`}`
`124`	`124`
`@@ -155,7 +155,7 @@ public Visibility LoadingCatalogControlVisibility {`
`155`	`155`	`set {`
`156`	`156`	`_loadingCatalogControlVisibility = value;`
`157`	`157`	`OnPropertyChanged();`
`158`		`- OnPropertyChanged("FilterControlsVisibility");`
	`158`	`+ OnPropertyChanged(nameof(FilterControlsVisibility));`
`159`	`159`	`}`
`160`	`160`	`}`
`161`	`161`
`@@ -258,7 +258,7 @@ private bool IsFiltering {`
`258`	`258`	`set {`
`259`	`259`	`_isFiltering = value;`
`260`	`260`	`OnPropertyChanged();`
`261`		`- OnPropertyChanged("PackageFilterState");`
	`261`	`+ OnPropertyChanged(nameof(PackageFilterState));`
`262`	`262`	`}`
`263`	`263`	`}`
`264`	`264`
`@@ -276,7 +276,7 @@ public IList<PackageCatalogEntryViewModel> FilteredPackages {`
`276`	`276`	`// PackageFilterState should be triggered before FilteredPackages`
`277`	`277`	`// to allow the UI to update the status before the package list,`
`278`	`278`	`// making for a smoother experience.`
`279`		`- OnPropertyChanged("PackageFilterState");`
	`279`	`+ OnPropertyChanged(nameof(PackageFilterState));`
`280`	`280`	`OnPropertyChanged();`
`281`	`281`	`}`
`282`	`282`	`}`
`@@ -290,7 +290,7 @@ public string FilterText {`
`290`	`290`	`IsFiltering = !string.IsNullOrWhiteSpace(_filterText);`
`291`	`291`
`292`	`292`	`OnPropertyChanged();`
`293`		`- OnPropertyChanged("PackageFilterState");`
	`293`	`+ OnPropertyChanged(nameof(PackageFilterState));`
`294`	`294`	`}`
`295`	`295`	`}`
`296`	`296`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ public string BaselineFile {`
`80`	`80`	`set {`
`81`	`81`	`if (_baselineFile != value) {`
`82`	`82`	`_baselineFile = value;`
`83`		`- OnPropertyChanged("BaselineFile");`
	`83`	`+ OnPropertyChanged(nameof(BaselineFile));`
`84`	`84`	`}`
`85`	`85`	`}`
`86`	`86`	`}`
`@@ -95,7 +95,7 @@ public string ComparisonFile {`
`95`	`95`	`set {`
`96`	`96`	`if (_comparisonFile != value) {`
`97`	`97`	`_comparisonFile = value;`
`98`		`- OnPropertyChanged("ComparisonFile");`
	`98`	`+ OnPropertyChanged(nameof(ComparisonFile));`
`99`	`99`	`}`
`100`	`100`	`}`
`101`	`101`	`}`
`@@ -119,7 +119,7 @@ public bool IsValid {`
`119`	`119`	`private set {`
`120`	`120`	`if (_isValid != value) {`
`121`	`121`	`_isValid = value;`
`122`		`- OnPropertyChanged("IsValid");`
	`122`	`+ OnPropertyChanged(nameof(IsValid));`
`123`	`123`	`}`
`124`	`124`	`}`
`125`	`125`	`}`
Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ public ProjectTargetView Project {`
`127`	`127`	`set {`
`128`	`128`	`if (_project != value) {`
`129`	`129`	`_project = value;`
`130`		`- OnPropertyChanged("Project");`
	`130`	`+ OnPropertyChanged(nameof(Project));`
`131`	`131`	`}`
`132`	`132`	`}`
`133`	`133`	`}`
`@@ -142,7 +142,7 @@ public bool IsProjectSelected {`
`142`	`142`	`set {`
`143`	`143`	`if (_isProjectSelected != value) {`
`144`	`144`	`_isProjectSelected = value;`
`145`		`- OnPropertyChanged("IsProjectSelected");`
	`145`	`+ OnPropertyChanged(nameof(IsProjectSelected));`
`146`	`146`	`}`
`147`	`147`	`}`
`148`	`148`	`}`
`@@ -164,7 +164,7 @@ public StandaloneTargetView Standalone {`
`164`	`164`	`_standalone.PropertyChanged += Standalone_PropertyChanged;`
`165`	`165`	`}`
`166`	`166`
`167`		`- OnPropertyChanged("Standalone");`
	`167`	`+ OnPropertyChanged(nameof(Standalone));`
`168`	`168`	`}`
`169`	`169`	`}`
`170`	`170`	`}`
`@@ -179,7 +179,7 @@ public bool IsStandaloneSelected {`
`179`	`179`	`set {`
`180`	`180`	`if (_isStandaloneSelected != value) {`
`181`	`181`	`_isStandaloneSelected = value;`
`182`		`- OnPropertyChanged("IsStandaloneSelected");`
	`182`	`+ OnPropertyChanged(nameof(IsStandaloneSelected));`
`183`	`183`	`}`
`184`	`184`	`}`
`185`	`185`	`}`
`@@ -204,7 +204,7 @@ void ProfilingTargetView_PropertyChanged(object sender, PropertyChangedEventArgs`
`204`	`204`	`/// </summary>`
`205`	`205`	`private void Standalone_PropertyChanged(object sender, PropertyChangedEventArgs e) {`
`206`	`206`	`Debug.Assert(Standalone == sender);`
`207`		`- OnPropertyChanged("Standalone");`
	`207`	`+ OnPropertyChanged(nameof(Standalone));`
`208`	`208`	`}`
`209`	`209`
`210`	`210`
`@@ -218,7 +218,7 @@ public bool IsValid {`
`218`	`218`	`private set {`
`219`	`219`	`if (_isValid != value) {`
`220`	`220`	`_isValid = value;`
`221`		`- OnPropertyChanged("IsValid");`
	`221`	`+ OnPropertyChanged(nameof(IsValid));`
`222`	`222`	`}`
`223`	`223`	`}`
`224`	`224`	`}`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ public string InterpreterPath {`
`85`	`85`	`set {`
`86`	`86`	`if (_interpreterPath != value) {`
`87`	`87`	`_interpreterPath = value;`
`88`		`- OnPropertyChanged("InterpreterPath");`
	`88`	`+ OnPropertyChanged(nameof(InterpreterPath));`
`89`	`89`	`}`
`90`	`90`	`}`
`91`	`91`	`}`
`@@ -100,7 +100,7 @@ public string ScriptPath {`
`100`	`100`	`set {`
`101`	`101`	`if (_scriptPath != value) {`
`102`	`102`	`_scriptPath = value;`
`103`		`- OnPropertyChanged("ScriptPath");`
	`103`	`+ OnPropertyChanged(nameof(ScriptPath));`
`104`	`104`	`//if (string.IsNullOrEmpty(WorkingDirectory)) {`
`105`	`105`	`// WorkingDirectory = Path.GetDirectoryName(_scriptPath);`
`106`	`106`	`//}`
`@@ -118,7 +118,7 @@ public string WorkingDirectory {`
`118`	`118`	`set {`
`119`	`119`	`if (_workingDirectory != value) {`
`120`	`120`	`_workingDirectory = value;`
`121`		`- OnPropertyChanged("WorkingDirectory");`
	`121`	`+ OnPropertyChanged(nameof(WorkingDirectory));`
`122`	`122`	`}`
`123`	`123`	`}`
`124`	`124`	`}`
`@@ -133,7 +133,7 @@ public string Arguments {`
`133`	`133`	`set {`
`134`	`134`	`if (_arguments != value) {`
`135`	`135`	`_arguments = value;`
`136`		`- OnPropertyChanged("Arguments");`
	`136`	`+ OnPropertyChanged(nameof(Arguments));`
`137`	`137`	`}`
`138`	`138`	`}`
`139`	`139`	`}`
`@@ -164,7 +164,7 @@ public bool IsValid {`
`164`	`164`	`private set {`
`165`	`165`	`if (_isValid != value) {`
`166`	`166`	`_isValid = value;`
`167`		`- OnPropertyChanged("IsValid");`
	`167`	`+ OnPropertyChanged(nameof(IsValid));`
`168`	`168`	`}`
`169`	`169`	`}`
`170`	`170`	`}`