From d00075a07efce060df921d88bcdd35267a8105d3 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Wed, 2 Mar 2016 11:17:26 -0800 Subject: [PATCH 1/2] Added links to running our tests --- CONTRIBUTING.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ecea3a12a..f80f869f4 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -20,13 +20,13 @@ In order to help us improve code quality and make NTVS better in general, here a - If you're adding a new feature, explain the feature and its use cases. - Provide a high level explanation of your changes. This will help reviewers understand implementation choices and will speed up the review process. - Try to keep pull requests small and focused. -- Make sure that existing tests continue to pass. +- [Run our tests][running-test] to ensure existing tests continue to pass. - All new code must include tests. - For a bug fix, consider adding a test that would fail before your change, but passes now. - - Feel free to ask for advice if you are unsure how what to test or how to integrate into our test infrastructure. + - Feel free to ask for advice if you are unsure how what to test or how to integrate into [our test infrastructure][running-tests]. - There is no formal code style-guide, but please try to match the style of any file you are editing. -All pull requests are reviewed by one of the project maintainers before being merged in. If you are unsure of anything, feel free to ask a question. We're always happy to help. +All pull requests are reviewed by one of the project maintainers before being merged in. If you are unsure of anything, feel free to ask. We're always happy to help. ### Licensing and Legal Node.js Tools for Visual Studio is a member of [Microsoft](http://microsoft.github.io/) and operates under the [Apache 2.0 license](https://github.com/Microsoft/nodejstools/blob/master/LICENSE). @@ -36,4 +36,5 @@ Node.js Tools for Visual Studio is a member of [Microsoft](http://microsoft.gith All contributions will be made under the Apache 2.0 license. Please don’t submit anything with any other licensing statements. If you want to make a contribution that includes code that under a different license, please let us know so we can figure out what to do. Also, make sure you have the right to make your contribution, including clearance from your employer if applicable. -[cla]: https://cla.microsoft.com/ \ No newline at end of file +[cla]: https://cla.microsoft.com/ +[running-tests]: https://github.com/Microsoft/nodejstools/wiki/Running-Our-Tests \ No newline at end of file From 4ede9febab2474dd4c18e6dc31c3052309dcbe27 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Wed, 2 Mar 2016 11:20:38 -0800 Subject: [PATCH 2/2] Fix link --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f80f869f4..cc4b3d328 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -20,7 +20,7 @@ In order to help us improve code quality and make NTVS better in general, here a - If you're adding a new feature, explain the feature and its use cases. - Provide a high level explanation of your changes. This will help reviewers understand implementation choices and will speed up the review process. - Try to keep pull requests small and focused. -- [Run our tests][running-test] to ensure existing tests continue to pass. +- [Run our tests][running-tests] to ensure existing tests continue to pass. - All new code must include tests. - For a bug fix, consider adding a test that would fail before your change, but passes now. - Feel free to ask for advice if you are unsure how what to test or how to integrate into [our test infrastructure][running-tests].