Minor changes in symbol lookup. Added Nuget and reference source PDB sources.

Author: Vance Morrison

src/HeapDump/GCHeapDumper.cs

@@ -1760,8 +1760,7 @@ private void DumpAllSegments()
                 if (m_gcHeapDump.MemoryGraph.NodeCount >= m_maxNodeCount ||
                     m_gcHeapDump.MemoryGraph.DistinctRefCount + m_children.Count > m_maxNodeCount)
                 {
-                    m_log.WriteLine("WARNING, exceeded the maximum number of node allowed {0} (because dump will be larger than 4GB))",
-                        m_maxNodeCount);
+                    m_log.WriteLine("WARNING, exceeded the maximum number of node allowed {0}", m_maxNodeCount);
                     m_log.WriteLine("{0,5:f1}s: Truncating heap dump.", m_sw.Elapsed.TotalSeconds);
                     return;
                 }

src/TraceEvent/Symbols/SymbolPath.cs

@@ -72,17 +72,11 @@ public static string MicrosoftSymbolServerPath
 #if !PUBLIC_ONLY
                     if (ComputerNameExists("symweb.corp.microsoft.com"))
                         s_MicrosoftSymbolServerPath = "SRV*http://symweb.corp.microsoft.com";   // Internal Microsoft location.  
-                    else
-                        s_MicrosoftSymbolServerPath = "SRV*http://msdl.microsoft.com/download/symbols";
-
-                    // TODO Is this a hack? 
-                    if (SymbolPath.ComputerNameExists("ddrps.corp.microsoft.com"))
-                        s_MicrosoftSymbolServerPath = s_MicrosoftSymbolServerPath + ";" + @"SRV*\\ddrps.corp.microsoft.com\symbols";
-                    if (SymbolPath.ComputerNameExists("clrmain"))
-                        s_MicrosoftSymbolServerPath = s_MicrosoftSymbolServerPath + ";" + @"SRV*\\clrmain\symbols";
-#else
-                        s_MicrosoftSymbolServerPath = "SRV*http://msdl.microsoft.com/download/symbols";
 #endif
+                    s_MicrosoftSymbolServerPath = s_MicrosoftSymbolServerPath +
+                        ";" + @"SRV*http://msdl.microsoft.com/download/symbols" +   // Operatig system Symbols
+                        ";" + @"SRV*https://nuget.smbsrc.net" +                     // Nuget symbols
+                        ";" + @"SRV*http://referencesource.microsoft.com/symbols";  // .NET Runtime desktop symbols 
                 }
                 return s_MicrosoftSymbolServerPath;
             }

src/TraceEvent/Symbols/SymbolReader.cs

@@ -746,7 +746,12 @@ internal bool GetPhysicalFileFromServer(string serverPath, string pdbIndexPath,
                 {
                     if (Uri.IsWellFormedUriString(serverPath, UriKind.Absolute))
                     {
-                        var fullUri = serverPath + "/" + pdbIndexPath.Replace('\\', '/');
+                        var fullUri = serverPath;
+                        var tail = pdbIndexPath.Replace('\\', '/');
+                        if (!tail.StartsWith("/"))
+                            fullUri += "/" + tail;
+                        else
+                            fullUri += tail;
                         try
                         {
                             var req = (System.Net.HttpWebRequest)System.Net.HttpWebRequest.Create(fullUri);
@@ -1659,6 +1664,8 @@ internal void LogManagedInfo(string pdbName, Guid pdbGuid, int pdbAge)
         /// Gets the 'srcsvc' data stream from the PDB and return it in as a string.   Returns null if it is not present. 
         /// 
         /// There is a tool called pdbstr associated with srcsrv that basically does this.  
+        ///     pdbstr -r -s:srcsrv -p:PDBPATH
+        /// will dump it. 
         /// </summary>
         internal string GetSrcSrvStream()
         {
@@ -2115,6 +2122,21 @@ public bool ChecksumMatches
         /// information from the PDB from 'pdbPath'.   Will return a path to the returned file (uses 
         /// SourceCacheDirectory associated symbol reader for context where to put the file), 
         /// or null if unsuccessful.  
+        /// 
+        /// There is a tool called pdbstr associated with srcsrv that basically does this.  
+        ///     pdbstr -r -s:srcsrv -p:PDBPATH
+        /// will dump it. 
+        ///
+        /// The basic flow is 
+        /// 
+        /// There is a variables section and a files section
+        /// 
+        /// The file section is a list of items separated by *.   The first is the path, the rest are up to you
+        /// 
+        /// You form a command by using the SRCSRVTRG variable and substituting variables %var1 where var1 is the first item in the * separated list
+        /// There are special operators %fnfile%(XXX), etc that manipulate the string XXX (get file name, translate \ to / ...
+        /// 
+        /// If what is at the end is a valid URL it is looked up.   
         /// </summary>
         string GetSourceFromSrcServer()
         {
@@ -2162,7 +2184,7 @@ string GetSourceFromSrcServer()
                     if (pieces.Length >= 2)
                     {
                         var buildTimePath = pieces[0];
-                        // log.WriteLine("Found source {0} in the PDB", buildTimePath);
+                        log.WriteLine("Found source {0} in the PDB", buildTimePath);
                         if (string.Compare(BuildTimeFilePath, buildTimePath, StringComparison.OrdinalIgnoreCase) == 0)
                         {
                             // Create variables for each of the pieces.  
@@ -2174,7 +2196,6 @@ string GetSourceFromSrcServer()
                             {
                                 if (Uri.IsWellFormedUriString(target, UriKind.Absolute))
                                 {
-                                    log.WriteLine("Fetching file {0} from web.", target);
                                     var url = target;
                                     target = null;
                                     if (vars.ContainsKey("HTTP_ALIAS"))
@@ -2327,9 +2348,15 @@ private static string FindTfExe()
 
         private string SourceServerFetchVar(string variable, Dictionary<string, string> vars)
         {
+            var log = m_symbolModule.m_reader.m_log;
             string result = "";
             if (vars.TryGetValue(variable, out result))
+            {
+                if (0 <= result.IndexOf('%') )
+                    log.WriteLine("SourceServerFetchVar: Before Evaluation {0} = '{1}'", variable, result);
                 result = SourceServerEvaluate(result, vars);
+            }
+            log.WriteLine("SourceServerFetchVar: {0} = '{1}'", variable, result);
             return result;
         }