Skip to content

Commit 97a7e10

Browse files
authored
Merge pull request #1125 from amgleitman/upgrade-node-14
bump Node references from 12/14 to 14/16 (facebook#32980)
2 parents dd6d6b7 + c043719 commit 97a7e10

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

.circleci/config.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ jobs:
392392
- run:
393393
name: Configure Environment Variables
394394
command: |
395-
echo 'export PATH=/usr/local/opt/node@12/bin:$PATH' >> $BASH_ENV
395+
echo 'export PATH=/usr/local/opt/node@16/bin:$PATH' >> $BASH_ENV
396396
source $BASH_ENV
397397
398398
- with_brew_cache_span:
@@ -407,6 +407,12 @@ jobs:
407407
- brew_install:
408408
package: applesimutils
409409

410+
- run:
411+
name: Configure Node
412+
# Sourcing find-node.sh will ensure nvm is set up.
413+
# It also helps future invocation of find-node.sh prevent permission issue with nvm.sh.
414+
command: source scripts/find-node.sh && nvm install 16 && nvm alias default 16
415+
410416
- run:
411417
name: Configure Watchman
412418
command: touch .watchmanconfig
@@ -622,8 +628,8 @@ jobs:
622628
name: Install Node
623629
# Note: Version set separately for non-Windows builds, see above.
624630
command: |
625-
nvm install 14.17.0
626-
nvm use 14.17.0
631+
nvm install 16
632+
nvm use 16
627633
628634
# Setup Dependencies
629635
- run:

scripts/validate-ios-test-env.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ fi
2323
# Check that the correct version of node is installed
2424
NODE_VERSION="$(command node --version | sed 's/[-/a-zA-Z]//g' |sed 's/.\{2\}$//')"
2525

26-
if (( $(echo "${NODE_VERSION} < 12.0" | bc -l) )); then
26+
if (( $(echo "${NODE_VERSION} < 14.0" | bc -l) )); then
2727
echo "Node ${NODE_VERSION} detected. This version of Node is not supported."
2828
echo "See https://reactnative.dev/docs/getting-started.html for instructions."
2929
exit 1

0 commit comments

Comments
 (0)