From c043719f2735a9d912db45d06100518fdcd79d5e Mon Sep 17 00:00:00 2001 From: Lorenzo Sciandra Date: Fri, 28 Jan 2022 05:05:20 -0800 Subject: [PATCH] bump Node references from 12/14 to 14/16 (#32980) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Node 16 has been the LTS for quite some time now ([Oct 2021](https://nodejs.org/en/blog/release/v16.13.0/)), so this PR just wants to bring the RN OSS CI up to speed. (I realized that this was needed while doing the same for macos https://github.com/microsoft/react-native-macos/pull/997) [General] [Changed] - CI moved to Node 16. Pull Request resolved: https://github.com/facebook/react-native/pull/32980 Test Plan: CI itself is the test � locally no significant changes were experienced. Reviewed By: cortinico Differential Revision: D33821288 Pulled By: ShikaSD fbshipit-source-id: 4480ae1cb909e2b8d0b6abba4db76bbe71f0193e --- .circleci/config.yml | 12 +++++++++--- scripts/validate-ios-test-env.sh | 2 +- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 69976f4aa9b8c2..8490b5f7766c40 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -392,7 +392,7 @@ jobs: - run: name: Configure Environment Variables command: | - echo 'export PATH=/usr/local/opt/node@12/bin:$PATH' >> $BASH_ENV + echo 'export PATH=/usr/local/opt/node@16/bin:$PATH' >> $BASH_ENV source $BASH_ENV - with_brew_cache_span: @@ -407,6 +407,12 @@ jobs: - brew_install: package: applesimutils + - run: + name: Configure Node + # Sourcing find-node.sh will ensure nvm is set up. + # It also helps future invocation of find-node.sh prevent permission issue with nvm.sh. + command: source scripts/find-node.sh && nvm install 16 && nvm alias default 16 + - run: name: Configure Watchman command: touch .watchmanconfig @@ -622,8 +628,8 @@ jobs: name: Install Node # Note: Version set separately for non-Windows builds, see above. command: | - nvm install 14.17.0 - nvm use 14.17.0 + nvm install 16 + nvm use 16 # Setup Dependencies - run: diff --git a/scripts/validate-ios-test-env.sh b/scripts/validate-ios-test-env.sh index 3f87c191448332..494d1fa49965b6 100755 --- a/scripts/validate-ios-test-env.sh +++ b/scripts/validate-ios-test-env.sh @@ -23,7 +23,7 @@ fi # Check that the correct version of node is installed NODE_VERSION="$(command node --version | sed 's/[-/a-zA-Z]//g' |sed 's/.\{2\}$//')" -if (( $(echo "${NODE_VERSION} < 12.0" | bc -l) )); then +if (( $(echo "${NODE_VERSION} < 14.0" | bc -l) )); then echo "Node ${NODE_VERSION} detected. This version of Node is not supported." echo "See https://reactnative.dev/docs/getting-started.html for instructions." exit 1