Skip to content
This repository was archived by the owner on Oct 11, 2022. It is now read-only.

Added docs for dynamic data display name#39

Merged
jayaranigarg merged 2 commits into
microsoft:masterfrom
bstoney:dynamic-display-name
Apr 12, 2018
Merged

Added docs for dynamic data display name#39
jayaranigarg merged 2 commits into
microsoft:masterfrom
bstoney:dynamic-display-name

Conversation

@bstoney

@bstoney bstoney commented Apr 10, 2018

Copy link
Copy Markdown
Contributor

Updating DynamicData attribute docs to include changed in PR microsoft/testfx#373 as requested by @smadala

Comment thread RFCs/006-DynamicData-Attribute.md Outdated
`DynamicDataDisplayNameDeclaringType` should be used in cases where the dynamic data display name method exists in a class other than the test class

```csharp
[DynamicData("ReusableTestDataMethod", DynamicDataDisplayName = "GetCustomDynamicDataDisplayName", DynamicDataDisplayNameDeclaringType = type(UnitTests))]

@jayaranigarg jayaranigarg Apr 11, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: typeOf(UnitTests)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice pick up 👍

@jayaranigarg

Copy link
Copy Markdown
Member

@bstoney : Thanks a bunch for updating the documentation. Just a small typo. Please fix that and we should be all good to push both your Pull Requests in 😄

@jayaranigarg jayaranigarg merged commit be317d6 into microsoft:master Apr 12, 2018
@bstoney bstoney deleted the dynamic-display-name branch April 12, 2018 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants