diff --git a/test/UnitTests/Microsoft.Testing.Platform.UnitTests/Logging/LoggingManagerTests.cs b/test/UnitTests/Microsoft.Testing.Platform.UnitTests/Logging/LoggingManagerTests.cs index e74aad6708..b518908ac3 100644 --- a/test/UnitTests/Microsoft.Testing.Platform.UnitTests/Logging/LoggingManagerTests.cs +++ b/test/UnitTests/Microsoft.Testing.Platform.UnitTests/Logging/LoggingManagerTests.cs @@ -9,12 +9,6 @@ namespace Microsoft.Testing.Platform.UnitTests; -internal interface IExtensionLoggerProvider : ILoggerProvider, IExtension; - -internal interface IInitializableLoggerProvider : ILoggerProvider, IAsyncInitializableExtension; - -internal interface IInitializableExtensionLoggerProvider : ILoggerProvider, IExtension, IAsyncInitializableExtension; - [TestClass] public sealed class LoggingManagerTests { @@ -22,7 +16,7 @@ public sealed class LoggingManagerTests private readonly Mock _mockMonitor = new(); public LoggingManagerTests() - => _mockMonitor.Setup(x => x.Lock(It.IsAny())).Returns(new Mock().Object); + => _mockMonitor.Setup(m => m.Lock(It.IsAny())).Returns(new Mock().Object); [TestMethod] public async Task BuildAsync_WithNoProviders_ReturnsFactoryThatCreatesLogger() @@ -129,7 +123,10 @@ public async Task BuildAsync_WithNonExtensionInitializableProvider_CallsInitiali } [TestMethod] - public async Task BuildAsync_PassesLogLevelAndServiceProviderToFactory() + [DataRow(LogLevel.Trace)] + [DataRow(LogLevel.Warning)] + [DataRow(LogLevel.Critical)] + public async Task BuildAsync_PassesLogLevelAndServiceProviderToFactory(LogLevel level) { LogLevel capturedLogLevel = LogLevel.None; IServiceProvider? capturedServiceProvider = null; @@ -138,16 +135,16 @@ public async Task BuildAsync_PassesLogLevelAndServiceProviderToFactory() mockProvider.Setup(p => p.CreateLogger(It.IsAny())).Returns(new Mock().Object); LoggingManager manager = new(); - manager.AddProvider((level, sp) => + manager.AddProvider((l, sp) => { - capturedLogLevel = level; + capturedLogLevel = l; capturedServiceProvider = sp; return mockProvider.Object; }); - _ = await manager.BuildAsync(_mockServiceProvider.Object, LogLevel.Warning, _mockMonitor.Object); + _ = await manager.BuildAsync(_mockServiceProvider.Object, level, _mockMonitor.Object); - Assert.AreEqual(LogLevel.Warning, capturedLogLevel); + Assert.AreEqual(level, capturedLogLevel); Assert.AreSame(_mockServiceProvider.Object, capturedServiceProvider); }