From 54a3d3cb894596fe4e6c8d7bdb2ee5bccfacc0ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Amaury=20Lev=C3=A9?= Date: Mon, 18 May 2026 13:42:16 +0200 Subject: [PATCH] Sanitize ODBC sample connection string to unblock dnceng mirror The doc-comment in TestDataConnectionSql.Helpers.cs contained the literal substring `Pwd=password`, which Azure DevOps push protection flags as an embedded credential (VS403654), causing the GitHub -> AzDO mirror of microsoft/testfx to fail (#8291). The same comment lived in TestDataConnectionSql.cs since 2016 and had been mirrored long before push protection started flagging it. The recent refactor (#8270) re-introduced the pattern in a new file, which triggered the scanner on every subsequent fast-forward push. Replace `Uid=user;Pwd=password` with `Uid=;Pwd=` so the example remains useful but no longer matches the connection-string-with- credentials detector. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../Data/TestDataConnectionSql.Helpers.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Adapter/MSTestAdapter.PlatformServices/Data/TestDataConnectionSql.Helpers.cs b/src/Adapter/MSTestAdapter.PlatformServices/Data/TestDataConnectionSql.Helpers.cs index 8a99bf5fc0..393042a445 100644 --- a/src/Adapter/MSTestAdapter.PlatformServices/Data/TestDataConnectionSql.Helpers.cs +++ b/src/Adapter/MSTestAdapter.PlatformServices/Data/TestDataConnectionSql.Helpers.cs @@ -104,7 +104,7 @@ protected static class KnownOleDbProviderNames /// /// /// sqlsrv32.dll: Driver={SQL Server};Server=SqlServer;Database=DatabaseName;Trusted_Connection=yes - /// msorcl32.dll: Driver={Microsoft ODBC for Oracle};Server=OracleServer;Uid=user;Pwd=password. + /// msorcl32.dll: Driver={Microsoft ODBC for Oracle};Server=OracleServer;Uid=<user>;Pwd=<password>. /// protected static class KnownOdbcDrivers {