From 21f15f141c6c687f1beebd66ebaf32c5ae097416 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Amaury=20Lev=C3=A9?= Date: Mon, 22 Jun 2026 13:16:05 +0200 Subject: [PATCH 1/2] Fix vendored-files manifest paths for relocated source-gen helpers The scheduled vendored-source check failed because three manifest entries pointed at MSTest.SourceGeneration/Helpers files removed by refactoring (#8586, #9118): - Repoint source-gen-equatable-array to src/Analyzers/Shared/EquatableArray.cs. - Repoint symbol-visibility to the surviving analyzers copy and rename id to analyzers-symbol-visibility. - Remove redundant source-gen-system-polyfills (NotNullWhenAttribute vendored content was dropped; same upstream NullableAttributes.cs is already tracked by polyfill-nullable-attributes). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- eng/vendored-files.json | 25 +++++-------------------- 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/eng/vendored-files.json b/eng/vendored-files.json index 48f0305716..baaad2dfee 100644 --- a/eng/vendored-files.json +++ b/eng/vendored-files.json @@ -17,24 +17,9 @@ ] }, { - "id": "source-gen-system-polyfills", - "local_path": "src/Analyzers/MSTest.SourceGeneration/Helpers/SystemPolyfills.cs", - "notes": "Nullable attribute polyfills for source generator. Only NotNullWhenAttribute is mirrored locally; combined with a locally-defined IsExternalInit shim. Originally referenced retired dotnet/coreclr@60f1e626 -- successor file lives in dotnet/runtime with the same content.", - "sources": [ - { - "repo": "dotnet/runtime", - "ref": "main", - "path": "src/libraries/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/NullableAttributes.cs", - "baseline_ref_sha": "906c53718074c669286fd5b0cd88bc7a56a0cd10", - "baseline_blob_sha": "78908b119ae07e92f7e89fe507eb0fc69b21fa99", - "scope": "NotNullWhenAttribute only; combined with locally-defined IsExternalInit" - } - ] - }, - { - "id": "source-gen-symbol-visibility", - "local_path": "src/Analyzers/MSTest.SourceGeneration/Helpers/SymbolVisibility.cs", - "notes": "Verbatim copy with namespace adjustment. Previously sourced from dotnet/roslyn-analyzers, which was archived and moved into dotnet/sdk.", + "id": "analyzers-symbol-visibility", + "local_path": "src/Analyzers/MSTest.Analyzers/RoslynAnalyzerHelpers/SymbolVisibility.cs", + "notes": "Verbatim copy with namespace adjustment. Previously sourced from dotnet/roslyn-analyzers, which was archived and moved into dotnet/sdk. The former MSTest.SourceGeneration copy was removed (#8586) in favor of a locally-authored SymbolAccessibilityHelper; this analyzers copy of the same upstream file remains the tracked vendored source.", "sources": [ { "repo": "dotnet/sdk", @@ -296,8 +281,8 @@ }, { "id": "source-gen-equatable-array", - "local_path": "src/Analyzers/MSTest.SourceGeneration/Helpers/EquatableArray{T}.cs", - "notes": "Value-equality wrapper over ImmutableArray for incremental source generator caching, ported from ComputeSharp.", + "local_path": "src/Analyzers/Shared/EquatableArray.cs", + "notes": "Value-equality wrapper over ImmutableArray for incremental source generator caching, ported from ComputeSharp. Shared across the MSTest source generators (#9118).", "sources": [ { "repo": "Sergio0694/ComputeSharp", From 521458d140a228f52a6f76d04bf7da81165b8be0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Amaury=20Lev=C3=A9?= Date: Mon, 22 Jun 2026 13:27:16 +0200 Subject: [PATCH 2/2] Rename equatable-array manifest id to reflect shared scope Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- eng/vendored-files.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/vendored-files.json b/eng/vendored-files.json index baaad2dfee..d4373d0f5a 100644 --- a/eng/vendored-files.json +++ b/eng/vendored-files.json @@ -280,7 +280,7 @@ ] }, { - "id": "source-gen-equatable-array", + "id": "shared-equatable-array", "local_path": "src/Analyzers/Shared/EquatableArray.cs", "notes": "Value-equality wrapper over ImmutableArray for incremental source generator caching, ported from ComputeSharp. Shared across the MSTest source generators (#9118).", "sources": [