From 97031d72b14c19c8c5766123a0474ead91ba5438 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 29 Jul 2026 15:36:42 +0000 Subject: [PATCH 1/3] Initial plan From c2662d9c98755027206f3e8fceb0d146da361214 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 29 Jul 2026 15:41:57 +0000 Subject: [PATCH 2/3] Remove VSCode 1.129.1 pin now that 1.131.0 is released Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com> --- .../changes/reenable-vscode-e2e-tests-2026-7-24-0-0-0.md | 2 +- packages/typespec-vscode/package.json | 2 +- .../test/extension/common/download-setup.ts | 7 +------ 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/.chronus/changes/reenable-vscode-e2e-tests-2026-7-24-0-0-0.md b/.chronus/changes/reenable-vscode-e2e-tests-2026-7-24-0-0-0.md index ce1374a1365..cf0935de05d 100644 --- a/.chronus/changes/reenable-vscode-e2e-tests-2026-7-24-0-0-0.md +++ b/.chronus/changes/reenable-vscode-e2e-tests-2026-7-24-0-0-0.md @@ -4,4 +4,4 @@ packages: - typespec-vscode --- -Re-enable the VS Code e2e tests (`test:web` and `test:extension`) that were temporarily skipped due to a hang in CI with the VS Code 1.130.0 release. Both tests are now pinned to VS Code 1.129.1 to avoid the regression until it is fixed upstream. +Re-enable the VS Code e2e tests (`test:web` and `test:extension`) that were temporarily skipped due to a hang in CI with the VS Code 1.130.0 release. The regression was fixed in VS Code 1.131.0, so the version pin has been removed and tests now run against the latest stable VS Code release. diff --git a/packages/typespec-vscode/package.json b/packages/typespec-vscode/package.json index ac4b08020b3..4fd11433365 100644 --- a/packages/typespec-vscode/package.json +++ b/packages/typespec-vscode/package.json @@ -282,7 +282,7 @@ "deploy": "vsce publish", "open-in-browser": "vscode-test-web --extensionDevelopmentPath=. .", "test:e2e": "pnpm test:web && pnpm test:extension", - "test:web": "vscode-test-web --quality stable --commit=8a7abeba6e03ea3af87bfbce9a1b7e48fed567b8 --extensionDevelopmentPath=. --headless --extensionTestsPath=dist/test/web/suite.js ./test/web/data", + "test:web": "vscode-test-web --quality stable --extensionDevelopmentPath=. --headless --extensionTestsPath=dist/test/web/suite.js ./test/web/data", "test:extension": "vitest run --root test/extension" }, "devDependencies": { diff --git a/packages/typespec-vscode/test/extension/common/download-setup.ts b/packages/typespec-vscode/test/extension/common/download-setup.ts index 42fbc7a57be..7902a37f7d8 100644 --- a/packages/typespec-vscode/test/extension/common/download-setup.ts +++ b/packages/typespec-vscode/test/extension/common/download-setup.ts @@ -1,11 +1,6 @@ import { download } from "@vscode/test-electron"; import type { TestProject } from "vitest/node"; -// VS Code 1.130.0 introduced a regression that causes the E2E tests to hang. -// Pin to 1.129.1 until the regression is resolved in a later release. -// See https://github.com/microsoft/typespec/issues/11369 -const VSCODE_PINNED_VERSION = "1.129.1"; - /** * The global method will download a brand new vscode to your local computer. * Subsequent cases will be executed in this vscode. @@ -14,7 +9,7 @@ export default async function downloadVscode({ provide }: TestProject) { if (process.env.VSCODE_E2E_DOWNLOAD_PATH) { provide("executablePath", process.env.VSCODE_E2E_DOWNLOAD_PATH); } else { - provide("executablePath", await download({ version: VSCODE_PINNED_VERSION })); + provide("executablePath", await download()); } } From 327753c24e89e71b10266ca9a99a9379ec1ed330 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 30 Jul 2026 17:17:41 +0000 Subject: [PATCH 3/3] =?UTF-8?q?Revert=20VSCode=20pin=20removal=20=E2=80=94?= =?UTF-8?q?=201.131.0=20still=20hangs=20in=20CI?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com> --- .../changes/reenable-vscode-e2e-tests-2026-7-24-0-0-0.md | 2 +- packages/typespec-vscode/package.json | 2 +- .../test/extension/common/download-setup.ts | 7 ++++++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.chronus/changes/reenable-vscode-e2e-tests-2026-7-24-0-0-0.md b/.chronus/changes/reenable-vscode-e2e-tests-2026-7-24-0-0-0.md index cf0935de05d..ce1374a1365 100644 --- a/.chronus/changes/reenable-vscode-e2e-tests-2026-7-24-0-0-0.md +++ b/.chronus/changes/reenable-vscode-e2e-tests-2026-7-24-0-0-0.md @@ -4,4 +4,4 @@ packages: - typespec-vscode --- -Re-enable the VS Code e2e tests (`test:web` and `test:extension`) that were temporarily skipped due to a hang in CI with the VS Code 1.130.0 release. The regression was fixed in VS Code 1.131.0, so the version pin has been removed and tests now run against the latest stable VS Code release. +Re-enable the VS Code e2e tests (`test:web` and `test:extension`) that were temporarily skipped due to a hang in CI with the VS Code 1.130.0 release. Both tests are now pinned to VS Code 1.129.1 to avoid the regression until it is fixed upstream. diff --git a/packages/typespec-vscode/package.json b/packages/typespec-vscode/package.json index 4fd11433365..ac4b08020b3 100644 --- a/packages/typespec-vscode/package.json +++ b/packages/typespec-vscode/package.json @@ -282,7 +282,7 @@ "deploy": "vsce publish", "open-in-browser": "vscode-test-web --extensionDevelopmentPath=. .", "test:e2e": "pnpm test:web && pnpm test:extension", - "test:web": "vscode-test-web --quality stable --extensionDevelopmentPath=. --headless --extensionTestsPath=dist/test/web/suite.js ./test/web/data", + "test:web": "vscode-test-web --quality stable --commit=8a7abeba6e03ea3af87bfbce9a1b7e48fed567b8 --extensionDevelopmentPath=. --headless --extensionTestsPath=dist/test/web/suite.js ./test/web/data", "test:extension": "vitest run --root test/extension" }, "devDependencies": { diff --git a/packages/typespec-vscode/test/extension/common/download-setup.ts b/packages/typespec-vscode/test/extension/common/download-setup.ts index 7902a37f7d8..42fbc7a57be 100644 --- a/packages/typespec-vscode/test/extension/common/download-setup.ts +++ b/packages/typespec-vscode/test/extension/common/download-setup.ts @@ -1,6 +1,11 @@ import { download } from "@vscode/test-electron"; import type { TestProject } from "vitest/node"; +// VS Code 1.130.0 introduced a regression that causes the E2E tests to hang. +// Pin to 1.129.1 until the regression is resolved in a later release. +// See https://github.com/microsoft/typespec/issues/11369 +const VSCODE_PINNED_VERSION = "1.129.1"; + /** * The global method will download a brand new vscode to your local computer. * Subsequent cases will be executed in this vscode. @@ -9,7 +14,7 @@ export default async function downloadVscode({ provide }: TestProject) { if (process.env.VSCODE_E2E_DOWNLOAD_PATH) { provide("executablePath", process.env.VSCODE_E2E_DOWNLOAD_PATH); } else { - provide("executablePath", await download()); + provide("executablePath", await download({ version: VSCODE_PINNED_VERSION })); } }