Skip to content

Commit f70e671

Browse files
author
Kartik Raj
committed
corrections
1 parent 942cd9a commit f70e671

5 files changed

Lines changed: 21 additions & 21 deletions

File tree

src/client/providers/symbolProvider.ts

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -147,23 +147,23 @@ export class JediSymbolProvider implements DocumentSymbolProvider {
147147

148148
// This does not appear to be used anywhere currently...
149149
// tslint:disable-next-line:no-unused-variable
150-
private provideDocumentSymbolsUnthrottled(document: TextDocument, token: CancellationToken): Thenable<SymbolInformation[]> {
151-
const filename = document.fileName;
152-
153-
const cmd: proxy.ICommand<proxy.ISymbolResult> = {
154-
command: proxy.CommandType.Symbols,
155-
fileName: filename,
156-
columnIndex: 0,
157-
lineIndex: 0
158-
};
159-
160-
if (document.isDirty) {
161-
cmd.source = document.getText();
162-
}
163-
164-
return this.jediFactory.getJediProxyHandler<proxy.ISymbolResult>(document.uri).sendCommandNonCancellableCommand(cmd, token)
165-
.then(data => this.parseData(document, data));
166-
}
150+
// private provideDocumentSymbolsUnthrottled(document: TextDocument, token: CancellationToken): Thenable<SymbolInformation[]> {
151+
// const filename = document.fileName;
152+
153+
// const cmd: proxy.ICommand<proxy.ISymbolResult> = {
154+
// command: proxy.CommandType.Symbols,
155+
// fileName: filename,
156+
// columnIndex: 0,
157+
// lineIndex: 0
158+
// };
159+
160+
// if (document.isDirty) {
161+
// cmd.source = document.getText();
162+
// }
163+
164+
// return this.jediFactory.getJediProxyHandler<proxy.ISymbolResult>(document.uri).sendCommandNonCancellableCommand(cmd, token)
165+
// .then(data => this.parseData(document, data));
166+
// }
167167

168168
private parseData(document: TextDocument, data?: proxy.ISymbolResult): SymbolInformation[] {
169169
if (data) {

src/client/unittests/common/xUnitParser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export function updateResultsFromXmlLogFile(tests: Tests, outputXmlFile: string,
5757
}
5858
// tslint:disable-next-line:no-require-imports
5959
const xml2js = require('xml2js');
60-
xml2js.parseString(data, (error, parserResult) => {
60+
xml2js.parseString(data, (error: Error, parserResult: { testsuite: TestSuiteResult }) => {
6161
if (error) {
6262
return reject(error);
6363
}

src/client/unittests/display/main.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export class TestResultDisplay implements ITestResultDisplay {
1717
private statusBar: StatusBarItem;
1818
private discoverCounter = 0;
1919
private ticker = ['|', '/', '-', '|', '/', '-', '\\'];
20-
private progressTimeout;
20+
private progressTimeout: NodeJS.Timer | null = null;
2121
private _enabled: boolean = false;
2222
private progressPrefix!: string;
2323
private readonly didChange = new EventEmitter<void>();

src/client/unittests/pytest/services/testMessageService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export class TestMessageService implements ITestMessageService {
2525
* @param testResults Details about all known tests.
2626
*/
2727
public async getFilteredTestMessages(rootDirectory: string, testResults: Tests): Promise<IPythonUnitTestMessage[]> {
28-
const testFuncs: FlattenedTestFunction[] = testResults.testFunctions.reduce<FlattenedTestFunction[]>((filtered, test) => {
28+
const testFuncs = testResults.testFunctions.reduce<FlattenedTestFunction[]>((filtered, test) => {
2929
if (test.testFunction.passed !== undefined || test.testFunction.status === TestStatus.Skipped) {
3030
filtered.push(test);
3131
}

src/client/unittests/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ export interface IPythonUnitTestMessage {
130130
code: string | undefined;
131131
message?: string;
132132
severity: PythonUnitTestMessageSeverity;
133-
provider: string;
133+
provider: string | undefined;
134134
traceback?: string;
135135
testTime: number;
136136
status: TestStatus;

0 commit comments

Comments
 (0)