From 153e7f1f17a3225deabd7bde3768c7d543a9fb31 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Thu, 18 Feb 2016 22:59:33 -0800 Subject: [PATCH 1/2] Fix opening code via command line using relative paths Opening code using `code ..`, `code ../..` was opening the wrong directory since trailing '.' characters were being trimmed by the launch code. Fixes #3127 --- src/vs/workbench/electron-main/env.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/electron-main/env.ts b/src/vs/workbench/electron-main/env.ts index 7ba44a6f9d2795..de9f37352d7a7f 100644 --- a/src/vs/workbench/electron-main/env.ts +++ b/src/vs/workbench/electron-main/env.ts @@ -317,7 +317,9 @@ function massagePath(path: string): string { path = strings.trim(strings.trim(path, ' '), '\t'); // Remove trailing dots - path = strings.rtrim(path, '.'); + if (platform.isWindows) { + path = strings.rtrim(path, '.'); + } return path; } From 655def280e450fc80c5875a6a9e60427820220cc Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Mon, 22 Feb 2016 07:48:53 -0800 Subject: [PATCH 2/2] Remove trailing dot removal all together --- src/vs/workbench/electron-main/env.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/vs/workbench/electron-main/env.ts b/src/vs/workbench/electron-main/env.ts index de9f37352d7a7f..2e7322242116fa 100644 --- a/src/vs/workbench/electron-main/env.ts +++ b/src/vs/workbench/electron-main/env.ts @@ -316,11 +316,6 @@ function massagePath(path: string): string { // Trim whitespaces path = strings.trim(strings.trim(path, ' '), '\t'); - // Remove trailing dots - if (platform.isWindows) { - path = strings.rtrim(path, '.'); - } - return path; }