Skip to content

feat: Add large file upload - #347

Merged
rkodev merged 22 commits into
mainfrom
feat/large-file-upload
Feb 27, 2025
Merged

feat: Add large file upload#347
rkodev merged 22 commits into
mainfrom
feat/large-file-upload

Conversation

@rkodev

@rkodev rkodev commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

feat: Add large file upload

Resolve #7

@rkodev
rkodev force-pushed the feat/large-file-upload branch from e1f72ed to b374a1c Compare February 14, 2025 03:01
@rkodev
rkodev marked this pull request as ready for review February 21, 2025 06:17
@rkodev
rkodev requested a review from a team as a code owner February 21, 2025 06:17
Comment thread src/tasks/LargeFileUploadTask.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts Outdated
Comment thread src/tasks/UploadSlice.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts
Comment thread src/tasks/LargeFileResponseHandler.ts Outdated
Comment thread src/tasks/UploadSlice.ts

@andrueastman andrueastman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment from my end.

Comment thread src/tasks/UploadSlice.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts Outdated
Comment thread src/tasks/UploadSlice.ts

@baywet baywet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making great progress here! left a couple of additional comments

Comment thread src/tasks/SeekableStreamReader.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts Outdated

@baywet baywet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting really close, I think there was one minor oversight.

Comment thread src/tasks/LargeFileUploadTask.ts Outdated

@baywet baywet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes

@rkodev
rkodev merged commit 08c4c9e into main Feb 27, 2025
@rkodev
rkodev deleted the feat/large-file-upload branch February 27, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for large file upload

3 participants