Skip to content

Commit a30ff66

Browse files
author
iamsajjad
committed
fix zero '0' not appear in logs and add doc for methods
1 parent 0145bde commit a30ff66

File tree

1 file changed

+28
-7
lines changed

1 file changed

+28
-7
lines changed

quickping/quickping.py

Lines changed: 28 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,17 @@ def genAddresses(self):
5959
def pinger(self, thread, queue):
6060

6161
"""
62-
Pings subnet
62+
63+
pinger make thread that run this command
64+
```
65+
exec ping -c 1 <ipaddress>
66+
```
67+
68+
logging color
69+
cyan (start thead)
70+
green (active address)
71+
red (deactive address)
72+
6373
"""
6474

6575
self.logs.clear()
@@ -68,8 +78,8 @@ def pinger(self, thread, queue):
6878
address = queue.get()
6979

7080
if self.log:
71-
log = "{0} Thread <{1}> Pinging : {2}".format(time.ctime(),
72-
colorize(thread, fg="cyan"),
81+
log = "{0} thread *{1} pinging : {2}".format(time.ctime(),
82+
colorize(str(thread), fg="cyan"),
7383
colorize(address, fg="cyan"))
7484
self.logs.append(log)
7585
print(log)
@@ -80,13 +90,13 @@ def pinger(self, thread, queue):
8090

8191
if data == 0:
8292
if self.log:
83-
log = "{0} Active Address at : {1}".format(time.ctime(), colorize(address, fg="green"))
93+
log = "{0} active address at : {1}".format(time.ctime(), colorize(address, fg="green"))
8494
self.logs.append(log)
8595
print(log)
8696
self.activeAddresses.append(address)
8797
else:
8898
if self.log:
89-
log = "{0} Deactive Address at : {1}".format(time.ctime(), colorize(address, fg="red"))
99+
log = "{0} deactive address at : {1}".format(time.ctime(), colorize(address, fg="red"))
90100
self.logs.append(log)
91101
print(log)
92102
self.deactiveAddresses.append(address)
@@ -97,7 +107,10 @@ def pinger(self, thread, queue):
97107
def active(self):
98108

99109
"""
100-
return self.activeAddresses, self.deactiveAddresses
110+
111+
return self.activeAddresses
112+
and update the value of deactiveAddresses
113+
101114
"""
102115

103116
self.genAddresses()
@@ -116,7 +129,7 @@ def active(self):
116129
self.activeAddresses = list(dict.fromkeys(sorted(self.activeAddresses)))
117130
self.deactiveAddresses = list(dict.fromkeys(sorted(self.deactiveAddresses)))
118131

119-
#ratio add after this function run
132+
#ratio add after this method run
120133
self.ratio = {
121134
"addresses": len(self.addresses),
122135
"active": len(self.activeAddresses),
@@ -126,6 +139,14 @@ def active(self):
126139
return self.activeAddresses
127140

128141
def deactive(self):
142+
143+
"""
144+
145+
return self.deactiveAddresses
146+
and update the value of activeAddresses
147+
148+
"""
149+
129150
self.active()
130151
return self.deactiveAddresses
131152

0 commit comments

Comments
 (0)