[BE][Easy]: Enable clang-tidy check readability-misplaced-array-index (pytorch#116210)

Skylion007 · pytorchmergebot · commit ff4aac109a99 · 2023-12-21T15:09:10.000Z
Enable clang-tidy check readability which checks for a bizarre C++ construct that is usually indicative of an error: https://clang.llvm.org/extra/clang-tidy/checks/readability/misplaced-array-index.html (indexing a number by a pointer, which surprisingly inverts the operands). Pull Request resolved: pytorch#116210 Approved by: https://github.com/albanD, https://github.com/malfet
diff --git a/.clang-tidy b/.clang-tidy
@@ -54,6 +54,7 @@ performance-*,
 readability-container-size-empty,
 readability-delete-null-pointer,
 readability-duplicate-include
+readability-misplaced-array-index,
 readability-string-compare,
 '
 HeaderFilterRegex: '^(aten/|c10/|torch/).*$'

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,7 @@ performance-*,`
`54`	`54`	`readability-container-size-empty,`
`55`	`55`	`readability-delete-null-pointer,`
`56`	`56`	`readability-duplicate-include`
	`57`	`+readability-misplaced-array-index,`
`57`	`58`	`readability-string-compare,`
`58`	`59`	`'`
`59`	`60`	`HeaderFilterRegex: '^(aten/\|c10/\|torch/).*$'`