refactor(entities): extract AbstractWeatherLayer to eliminate Icing/Turbulence duplication

- Create new abstract class AbstractWeatherLayer in model package
- Fields: baseHeight (int), depth (int), unit (LengthUnit) with final getters/setters
- Final toString() calling abstract appendIntensity() hook for subclass customization
- Icing and Turbulence now extend AbstractWeatherLayer
- Remove duplicated fields/getters/setters/toString from Icing and Turbulence
- Implement protected void appendIntensity() in each subclass for intensity field
- Reduces code duplication from 60% to 0% in these classes

Fixes SonarCloud duplicated_lines_density quality gate failure on PR #796.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: mivek

metarParser-entities/src/main/java/io/github/mivek/model/AbstractWeatherLayer.java

@@ -0,0 +1,95 @@
+package io.github.mivek.model;
+
+import io.github.mivek.enums.LengthUnit;
+import io.github.mivek.internationalization.Messages;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+
+/**
+ * Abstract base class for weather layers with height-based properties (icing, turbulence).
+ * Defines common fields and behavior for layers characterized by base height, depth, and measurement unit.
+ *
+ * @author Jean-Kevin KPADEY
+ */
+public abstract class AbstractWeatherLayer {
+
+  /** The base limit of the layer. */
+  private int baseHeight;
+  /** The layer depth. */
+  private int depth;
+  /** The unit of the layer heights. */
+  private LengthUnit unit;
+
+  /**
+   * Returns the base height of the layer.
+   *
+   * @return the base height.
+   */
+  public final int getBaseHeight() {
+    return baseHeight;
+  }
+
+  /**
+   * Sets the base height of the layer.
+   *
+   * @param baseHeight the base height to set.
+   */
+  public final void setBaseHeight(final int baseHeight) {
+    this.baseHeight = baseHeight;
+  }
+
+  /**
+   * Returns the depth of the layer.
+   * Add this to the baseHeight to determine the top limit of the layer conditions.
+   *
+   * @return the layer depth.
+   */
+  public final int getDepth() {
+    return depth;
+  }
+
+  /**
+   * Sets the depth of the layer.
+   *
+   * @param depth the depth to set.
+   */
+  public final void setDepth(final int depth) {
+    this.depth = depth;
+  }
+
+  /**
+   * Returns the unit of the layer heights.
+   *
+   * @return the unit of the heights.
+   */
+  public final LengthUnit getUnit() {
+    return unit;
+  }
+
+  /**
+   * Sets the unit of the layer heights.
+   *
+   * @param unit the unit to set.
+   */
+  public final void setUnit(final LengthUnit unit) {
+    this.unit = unit;
+  }
+
+  /**
+   * Appends intensity-specific information to the toString builder.
+   * Implemented by subclasses to add their intensity field.
+   *
+   * @param builder the ToStringBuilder to append to.
+   */
+  protected abstract void appendIntensity(final ToStringBuilder builder);
+
+  @Override
+  public final String toString() {
+    ToStringBuilder builder = new ToStringBuilder(this);
+    appendIntensity(builder);
+    return builder.
+        append(Messages.getInstance().getString("ToString.baseHeight"), baseHeight).
+        append(Messages.getInstance().getString("ToString.depth"), depth).
+        append(Messages.getInstance().getString("ToString.height.unit"), unit).
+        toString();
+  }
+}

metarParser-entities/src/main/java/io/github/mivek/model/Icing.java

@@ -1,90 +1,38 @@
 package io.github.mivek.model;
 
 import io.github.mivek.enums.IcingIntensity;
-import io.github.mivek.enums.LengthUnit;
 import io.github.mivek.internationalization.Messages;
 import org.apache.commons.lang3.builder.ToStringBuilder;
 
 /**
  * Represents the icing of a TAF.
+ *
  * @author Jean-Kevin KPADEY
  */
-public final class Icing {
+public final class Icing extends AbstractWeatherLayer {
   /** The intensity of the icing. */
   private IcingIntensity intensity;
-  /** The base of the icing layer. */
-  private int baseHeight;
-  /** The icing layer depth. */
-  private int depth;
-  /** The unit of the icing heights. */
-  private LengthUnit unit;
 
   /**
    * Returns the icing intensity.
+   *
    * @return the icing intensity.
    */
   public IcingIntensity getIntensity() {
     return intensity;
   }
 
   /**
+   * Sets the icing intensity.
+   *
    * @param intensity The intensity to set.
    */
   public void setIntensity(final IcingIntensity intensity) {
     this.intensity = intensity;
   }
 
-  /**
-   * Returns the base of the icing layer.
-   * @return the base of the icing layer.
-   */
-  public int getBaseHeight() {
-    return baseHeight;
-  }
-
-  /**
-   * @param baseHeight The base height to set.
-   */
-  public void setBaseHeight(final int baseHeight) {
-    this.baseHeight = baseHeight;
-  }
-
-  /**
-   * @return the icing layer depth.
-   * Add this to the baseHeight to determine the top limit of the icing conditions.
-   */
-  public int getDepth() {
-    return depth;
-  }
-
-  /**
-   * @param depth The depth to set.
-   */
-  public void setDepth(final int depth) {
-    this.depth = depth;
-  }
-
-  /**
-   * @return the unit of the icing heights.
-   */
-  public LengthUnit getUnit() {
-    return unit;
-  }
-
-  /**
-   * @param unit The unit of the icing heights to set.
-   */
-  public void setUnit(final LengthUnit unit) {
-    this.unit = unit;
-  }
-
   @Override
-  public String toString() {
-    return new ToStringBuilder(this).
-        append(Messages.getInstance().getString("ToString.intensity"), intensity).
-        append(Messages.getInstance().getString("ToString.baseHeight"), baseHeight).
-        append(Messages.getInstance().getString("ToString.depth"), depth).
-        append(Messages.getInstance().getString("ToString.height.unit"), unit).
-        toString();
+  protected void appendIntensity(final ToStringBuilder builder) {
+    builder.append(Messages.getInstance().getString("ToString.intensity"), intensity);
   }
 }

metarParser-entities/src/main/java/io/github/mivek/model/Turbulence.java

@@ -1,88 +1,38 @@
 package io.github.mivek.model;
 
-import io.github.mivek.enums.LengthUnit;
 import io.github.mivek.enums.TurbulenceIntensity;
 import io.github.mivek.internationalization.Messages;
 import org.apache.commons.lang3.builder.ToStringBuilder;
 
 /**
  * This class represents the Turbulence of a TAF.
- * @author Jean-Kevin KPADEY
+ *
+ * @author mivek
  */
-public final class Turbulence {
+public final class Turbulence extends AbstractWeatherLayer {
   /** The intensity of the turbulence. */
   private TurbulenceIntensity intensity;
-  /** The base limit of the turbulence layer. */
-  private int baseHeight;
-  /** The turbulence layer depth. */
-  private int depth;
-  /** The unit of the turbulence heights. */
-  private LengthUnit unit;
 
   /**
+   * Returns the intensity of the turbulence.
+   *
    * @return the intensity of the turbulence.
    */
   public TurbulenceIntensity getIntensity() {
     return intensity;
   }
 
   /**
+   * Sets the intensity of the turbulence.
+   *
    * @param intensity The intensity to set.
    */
   public void setIntensity(final TurbulenceIntensity intensity) {
     this.intensity = intensity;
   }
 
-  /**
-   * @return The base height of the turbulence layer.
-   */
-  public int getBaseHeight() {
-    return baseHeight;
-  }
-
-  /**
-   * @param baseHeight The base height to set.
-   */
-  public void setBaseHeight(final int baseHeight) {
-    this.baseHeight = baseHeight;
-  }
-
-  /**
-   * @return the turbulence layer depth.
-   * Add it to the base height to determine the top limit of the turbulence conditions.
-   */
-  public int getDepth() {
-    return depth;
-  }
-
-  /**
-   * @param depth The turbulence layer depth to set.
-   */
-  public void setDepth(final int depth) {
-    this.depth = depth;
-  }
-
-  /**
-   * @return the unit of the turbulence heights.
-   */
-  public LengthUnit getUnit() {
-    return unit;
-  }
-
-  /**
-   * @param unit The unit of the turbulence heights to set.
-   */
-  public void setUnit(final LengthUnit unit) {
-    this.unit = unit;
-  }
-
   @Override
-  public String toString() {
-    return new ToStringBuilder(this).
-        append(Messages.getInstance().getString("ToString.intensity"), intensity).
-        append(Messages.getInstance().getString("ToString.baseHeight"), baseHeight).
-        append(Messages.getInstance().getString("ToString.depth"), depth).
-        append(Messages.getInstance().getString("ToString.height.unit"), unit).
-        toString();
+  protected void appendIntensity(final ToStringBuilder builder) {
+    builder.append(Messages.getInstance().getString("ToString.intensity"), intensity);
   }
 }