Adds test-generators for valid and invalid configuration files#1
Closed
funkyfuture wants to merge 1 commit into
Closed
Adds test-generators for valid and invalid configuration files#1funkyfuture wants to merge 1 commit into
funkyfuture wants to merge 1 commit into
Conversation
Signed-off-by: Frank Sachsenheim <funkyfuture@riseup.net>
Owner
|
Hi @funkyfuture, I've reviewed these test cases and I'm not going to merge this PR. The format of the tests is not in a style/format in-keeping with the rest of the project and is not as explicit in what it is testing for each case. This makes it harder to read and less accessible. A lot of the test cases that you report as "failing" are only failing according to newly-invented criteria, which (as stated in the discussion on PR docker#1808) is out of the scope for this first piece of work. For example, we don't currently validate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds testing of valid and invalid configuralions that i wrote for github.com/docker/pull/1355