Merge pull request #64 from mobify/fix-63

Fix #63

Author: Marlow Payne

CHANGELOG

@@ -1,3 +1,5 @@
+6.0.1
+  - Fix [#63](https://github.com/mobify/bellows/issues/63): Short circuit open if other items are opening
 6.0.0
   - Publish to NPM
   - Remove Zepto support in favor of jQuery

dist/bellows.js

@@ -137,6 +137,13 @@
                 .attr('aria-hidden', true);
         },
 
+        /*
+        Checks if other bellows items are currently opening
+        */
+        _othersAreOpening: function() {
+            return this.$bellows.find('.' + cssClasses.OPENING).length > 0;
+        },
+
         toggle: function($item) {
             $item = this._item($item);
 
@@ -155,6 +162,11 @@
 
             if (this.options.singleItemOpen) {
                 this.closeAll();
+
+                // Fix #63
+                if (this._othersAreOpening()) {
+                    return;
+                }
             }
 
             this._trigger('open', {item: $item});

dist/bellows.min.js

@@ -137,6 +137,13 @@
                 .attr('aria-hidden', true);
         },
 
+        /*
+        Checks if other bellows items are currently opening
+        */
+        _othersAreOpening: function() {
+            return this.$bellows.find('.' + cssClasses.OPENING).length > 0;
+        },
+
         toggle: function($item) {
             $item = this._item($item);
 
@@ -155,6 +162,11 @@
 
             if (this.options.singleItemOpen) {
                 this.closeAll();
+
+                // Fix #63
+                if (this._othersAreOpening()) {
+                    return;
+                }
             }
 
             this._trigger('open', {item: $item});

src/js/bellows.js

@@ -282,5 +282,20 @@ define([
                 expect($openDisabledItem.hasClass('bellows--is-open')).to.be.true;
             });
         });
+
+        describe('a Bellows instance with singleItemOpen set', function() {
+            it('only allows a single item open when opening another item', function() {
+                $element.bellows({
+                    singleItemOpen: true,
+                    opened: function() {
+                        $element.bellows('open', 1);
+                        $element.find('.bellows__item.bellows--is-open').to.have.length(1);
+                        done();
+                    }
+                });
+
+                $element.bellows('open', 0);
+            });
+        });
     });
 });