Migrate JS linting to eslint

Author: Marlow Payne

CHANGELOG

@@ -2,6 +2,7 @@
   - Publish to NPM
   - Remove Zepto support in favor of jQuery
   - Migrate all dependencies to NPM, remove Bower
+  - Migrate JS linting to eslint
 5.1.2
   - Ensuring disabled items don't close on close
 5.0.1

Gruntfile.js

@@ -1,4 +1,4 @@
-'use strict'
+'use strict';
 
 var path = require('path');
 
@@ -32,6 +32,7 @@ module.exports = function(grunt) {
         'grunt-contrib-watch',
         'grunt-contrib-connect',
         'grunt-css',
+        'grunt-eslint',
         'grunt-shell',
         'grunt-contrib-clean',
         'grunt-contrib-copy',
@@ -48,8 +49,8 @@ module.exports = function(grunt) {
     });
 
     grunt.registerTask('serve', ['build', 'connect:server', 'watch']);
-    grunt.registerTask('build', ['lint:dev', 'copy', 'uglify', 'version:all', 'sass', 'autoprefixer', 'cssmin']);
-    grunt.registerTask('release', ['lint:dev', 'test', 'shell:tagRelease']);
+    grunt.registerTask('build', ['lint:prod', 'copy', 'uglify', 'version:all', 'sass', 'autoprefixer', 'cssmin']);
+    grunt.registerTask('release', ['lint:prod', 'test', 'shell:tagRelease']);
     grunt.registerTask('test', ['build', 'connect:test', 'mocha_phantomjs']);
     grunt.registerTask('test:browser', ['build', 'connect:test:keepalive']);
     grunt.registerTask('default', 'build');

dist/bellows.js

@@ -9,7 +9,7 @@
         var framework = window.jQuery;
         factory(framework, framework.Velocity, window.Plugin);
     }
-}(function($, Velocity, Plugin) {
+})(function($, Velocity, Plugin) {
     var cssClasses = {
         ITEM: 'bellows__item',
         HEADER: 'bellows__header',
@@ -29,9 +29,9 @@
         CLICK: 'click.bellows'
     };
 
-    function Bellows(element, options) {
+    var Bellows = function(element, options) {
         Bellows.__super__.call(this, element, options, Bellows.DEFAULTS);
-    }
+    };
 
     Bellows.VERSION = '6.0.0';
 
@@ -254,4 +254,4 @@
     $('[data-bellows]').bellows();
 
     return $;
-}));
+});

dist/bellows.min.js

@@ -14,18 +14,16 @@
     "grunt-contrib-clean": "0.5.0",
     "grunt-contrib-connect": "0.9.0",
     "grunt-contrib-copy": "0.4.1",
-    "grunt-contrib-jshint": "0.10.0",
     "grunt-contrib-sass": "0.8.1",
     "grunt-contrib-uglify": "0.8.1",
     "grunt-contrib-watch": "0.5.3",
     "grunt-css": "0.5.4",
-    "grunt-jscs-checker": "0.4.1",
+    "grunt-eslint": "17.3.2",
     "grunt-mocha-phantomjs": "0.3.2",
     "grunt-open": "0.2.3",
     "grunt-shell": "0.2.2",
     "grunt-version": "0.3.3",
-    "jshint": "2.5.0",
-    "mobify-code-style": "0.0.3",
+    "mobify-code-style": "^2.4.2",
     "mocha": "1.14.0"
   },
   "license": "MIT",

package.json

@@ -9,7 +9,7 @@
         var framework = window.jQuery;
         factory(framework, framework.Velocity, window.Plugin);
     }
-}(function($, Velocity, Plugin) {
+})(function($, Velocity, Plugin) {
     var cssClasses = {
         ITEM: 'bellows__item',
         HEADER: 'bellows__header',
@@ -29,9 +29,9 @@
         CLICK: 'click.bellows'
     };
 
-    function Bellows(element, options) {
+    var Bellows = function(element, options) {
         Bellows.__super__.call(this, element, options, Bellows.DEFAULTS);
-    }
+    };
 
     Bellows.VERSION = '0';
 
@@ -254,4 +254,4 @@
     $('[data-bellows]').bellows();
 
     return $;
-}));
+});

src/js/bellows.js

@@ -0,0 +1,20 @@
+module.exports = function(grunt) {
+    var lint = require('../jslinting');
+
+    return {
+        prod: {
+            src: lint.targets,
+            options: {
+                reset: true,
+                config: require.resolve('mobify-code-style/javascript/.eslintrc-prod')
+            }
+        },
+        dev: {
+            src: lint.targets,
+            options: {
+                reset: true,
+                config: require.resolve('mobify-code-style/javascript/.eslintrc')
+            }
+        }
+    };
+};

tasks/config/eslint.js

@@ -0,0 +1,6 @@
+
+module.exports = function(grunt) {
+    grunt.registerTask('lint:dev', ['eslint:dev']);
+    grunt.registerTask('lint:prod', ['eslint:prod']);
+    grunt.registerTask('lint', ['lint:dev']);
+};