[23.0 backport] distribution: checkSupportedMediaType: allow additional media-types#44568
Merged
thaJeztah merged 1 commit intoDec 3, 2022
Conversation
This addresses a regression introduced in 407e3a4, which turned out to be "too strict", as there's old images that use, for example; docker pull python:3.5.1-alpine 3.5.1-alpine: Pulling from library/python unsupported media type application/octet-stream Before 407e3a4, such mediatypes were accepted; docker pull python:3.5.1-alpine 3.5.1-alpine: Pulling from library/python e110a4a17941: Pull complete 30dac23631f0: Pull complete 202fc3980a36: Pull complete Digest: sha256:f88925c97b9709dd6da0cb2f811726da9d724464e9be17a964c70f067d2aa64a Status: Downloaded newer image for python:3.5.1-alpine docker.io/library/python:3.5.1-alpine This patch copies the additional media-types, using the list of types that were added in a215e15, which fixed a similar issue. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit a6a5394) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
area/distribution
cpuguy83
approved these changes
Dec 2, 2022
Member
Author
|
Let me get this one in 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a regression introduced in 407e3a4 (#44367), which turned out to be "too strict", as there's old images that use, for example;
Before 407e3a4, such mediatypes were accepted;
This patch copies the additional media-types, using the list of types that were added in a215e15 (#30262), which fixed a similar issue.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)