Remove ability to use parameter name _session and _request #206
+40
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are reserved for internal use. This will fix #168
Motivation and Context
The
_sessionand_requestare used internally, they are not meant to be injected via argument injection.An alternative to this PR would be to remove them in
ReferenceHandler::prepareArguments(), but that would throw an exception when the tool is called. By doing it in theSchemaGeneratorwe get an exception when the server was startedHow Has This Been Tested?
I modified an example and tested.
Breaking Changes
No. I consider this a bug fix. See #168.
The "feature" of naming a variable
$_sessionis not documented nor covered by tests.Types of changes
Checklist
Additional context