fix: propagate refresh token persistence errors#2149
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
|
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
1389aad to
fa125f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2034.
When refresh-token flow succeeds but
provider.saveTokens()fails, the currentauth()path catches that persistence error in the sametryblock asrefreshAuthorization(). That makes the SDK fall through to a fresh authorization redirect even though the authorization server may already have rotated the refresh token.This separates the refresh request from token persistence. Refresh failures keep the existing fallback behavior, while persistence failures now propagate to the caller so filesystem or storage problems are visible and the client does not silently lose the newly issued tokens.
To verify
pnpm --filter @modelcontextprotocol/client exec vitest run test/client/auth.test.ts -t "propagates token persistence errors"pnpm --filter @modelcontextprotocol/client exec vitest run test/client/auth.test.tspnpm --filter @modelcontextprotocol/client typecheckpnpm --filter @modelcontextprotocol/client lintgit diff --checktypecheck,build, andlint