Skip to content

Commit 5764c79

Browse files
fix(ci): harden turbo devtools playwright setup
1 parent bba1fed commit 5764c79

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

.github/workflows/devtools.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ concurrency:
1111
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
1212
cancel-in-progress: true
1313

14-
env:
15-
PLAYWRIGHT_BROWSERS_PATH: 0
16-
1714
jobs:
1815
main:
1916
runs-on: ubuntu-latest
@@ -53,7 +50,7 @@ jobs:
5350
run: npx cypress install
5451

5552
- name: Install Playwright browsers
56-
run: pnpm exec playwright install chromium
53+
run: pnpm --filter @module-federation/devtools exec playwright install chromium
5754

5855
- name: Build shared packages
5956
run: pnpm run build:pkg

packages/chrome-devtools/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
"build:lib": "rm -rf dist && modern-module build -c modern.lib.config.ts",
1818
"release": "npm publish --tag canary",
1919
"test": "vitest run",
20-
"test:e2e": "E2ETEST=true pnpm build && playwright test",
21-
"test:e2e:ui": "E2ETEST=true pnpm build && playwright test --ui",
20+
"test:e2e": "node ../../scripts/ensure-playwright.js && E2ETEST=true pnpm build && playwright test",
21+
"test:e2e:ui": "node ../../scripts/ensure-playwright.js && E2ETEST=true pnpm build && playwright test --ui",
2222
"start": "modern-app start",
2323
"serve": "modern-app serve",
2424
"postinstall": "bash install-deps.bash",

turbo.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
{
22
"$schema": "https://turbo.build/schema.json",
3+
"globalPassThroughEnv": [
4+
"NEXT_PRIVATE_LOCAL_WEBPACK",
5+
"PLAYWRIGHT_BROWSERS_PATH"
6+
],
37
"tasks": {
48
"build": {
59
"dependsOn": ["^build"],

0 commit comments

Comments
 (0)