refactor(enhanced): export getAllReferencedModules as a util (#2937)

Author: ScriptedAlchemy

.github/workflows/devtools.yml

@@ -42,7 +42,7 @@ jobs:
         run: sudo apt-get update && sudo apt-get install xvfb
 
       - name: E2E Chrome Devtools
-        run: pnpm run app:manifest:dev & echo "done" && sleep 50 && npx nx e2e:devtools chrome-devtools
+        run: pnpm run app:manifest:dev & echo "done" && npx wait-on tcp:3009 tcp:3010 tcp:3011 tcp:3012 && sleep 10 && npx nx e2e:devtools chrome-devtools
 
       - name: kill port
         run: lsof -ti tcp:3008,3009,3010,3011,3012 | xargs kill

package.json

@@ -39,7 +39,7 @@
     "app:node:dev": "nx run-many --target=serve --parallel=10 --configuration=development -p node-host,node-local-remote,node-remote,node-dynamic-remote-new-version,node-dynamic-remote",
     "app:runtime:dev": "nx run-many --target=serve -p 3005-runtime-host,3006-runtime-remote,3007-runtime-remote",
     "app:router:dev": "nx run-many --target=serve --parallel=10 --projects='router-*'",
-    "app:manifest:dev": "kill-port 3009 3010 3011 3012 3013 && nx run-many --target=serve --parallel=100 -p manifest-webpack-host,3009-webpack-provider,3010-rspack-provider,3011-rspack-manifest-provider,3012-rspack-js-entry-provider",
+    "app:manifest:dev": "nx run-many --target=serve --parallel=100 -p manifest-webpack-host,3009-webpack-provider,3010-rspack-provider,3011-rspack-manifest-provider,3012-rspack-js-entry-provider",
     "app:ts:dev": "nx run-many --target=serve -p react_ts_host,react_ts_nested_remote,react_ts_remote",
     "app:modern:dev": "nx run-many --target=serve --parallel=10 --configuration=development -p modernjs-ssr-dynamic-nested-remote,modernjs-ssr-dynamic-remote,modernjs-ssr-dynamic-remote-new-version,modernjs-ssr-host,modernjs-ssr-nested-remote,modernjs-ssr-remote,modernjs-ssr-remote-new-version",
     "commitlint": "commitlint --edit",

packages/enhanced/src/lib/container/HoistContainerReferencesPlugin.ts

@@ -10,6 +10,7 @@ import { normalizeWebpackPath } from '@module-federation/sdk/normalize-webpack-p
 import type { RuntimeSpec } from 'webpack/lib/util/runtime';
 import type ExportsInfo from 'webpack/lib/ExportsInfo';
 import ContainerEntryModule from './ContainerEntryModule';
+import { moduleFederationPlugin } from '@module-federation/sdk';
 
 const { NormalModule, AsyncDependenciesBlock } = require(
   normalizeWebpackPath('webpack'),
@@ -29,15 +30,18 @@ export class HoistContainerReferences implements WebpackPluginInstance {
   private readonly entryFilePath?: string;
   private readonly bundlerRuntimeDep?: string;
   private readonly explanation: string;
+  private readonly experiments: moduleFederationPlugin.ModuleFederationPluginOptions['experiments'];
 
   constructor(
     name?: string,
     entryFilePath?: string,
     bundlerRuntimeDep?: string,
+    experiments?: moduleFederationPlugin.ModuleFederationPluginOptions['experiments'],
   ) {
     this.containerName = name || 'no known chunk name';
     this.entryFilePath = entryFilePath;
     this.bundlerRuntimeDep = bundlerRuntimeDep;
+    this.experiments = experiments;
     this.explanation =
       'Bundler runtime path module is required for proper functioning';
   }
@@ -92,7 +96,7 @@ export class HoistContainerReferences implements WebpackPluginInstance {
                   module instanceof NormalModule &&
                   module.resource === this.bundlerRuntimeDep
                 ) {
-                  const allRefs = this.getAllReferencedModules(
+                  const allRefs = getAllReferencedModules(
                     compilation,
                     module,
                     'initial',
@@ -119,40 +123,6 @@ export class HoistContainerReferences implements WebpackPluginInstance {
     );
   }
 
-  // Helper method to collect all referenced modules recursively
-  private getAllReferencedModules(
-    compilation: Compilation,
-    module: Module,
-    type?: 'all' | 'initial',
-  ): Set<Module> {
-    const collectedModules = new Set<Module>([module]);
-    const stack = [module];
-
-    while (stack.length > 0) {
-      const currentModule = stack.pop();
-      if (!currentModule) continue;
-      const mgm = compilation.moduleGraph._getModuleGraphModule(currentModule);
-      if (mgm && mgm.outgoingConnections) {
-        for (const connection of mgm.outgoingConnections) {
-          if (type === 'initial') {
-            const parentBlock = compilation.moduleGraph.getParentBlock(
-              connection.dependency,
-            );
-            if (parentBlock instanceof AsyncDependenciesBlock) {
-              continue;
-            }
-          }
-          if (connection.module && !collectedModules.has(connection.module)) {
-            collectedModules.add(connection.module);
-            stack.push(connection.module);
-          }
-        }
-      }
-    }
-
-    return collectedModules;
-  }
-
   // Helper method to find a specific module in a chunk
   private findModule(
     compilation: Compilation,
@@ -226,7 +196,7 @@ export class HoistContainerReferences implements WebpackPluginInstance {
       return;
     }
 
-    const allReferencedModules = this.getAllReferencedModules(
+    const allReferencedModules = getAllReferencedModules(
       compilation,
       runtimeModule,
       'initial',
@@ -291,4 +261,38 @@ export class HoistContainerReferences implements WebpackPluginInstance {
   }
 }
 
+// Helper method to collect all referenced modules recursively
+export function getAllReferencedModules(
+  compilation: Compilation,
+  module: Module,
+  type?: 'all' | 'initial',
+): Set<Module> {
+  const collectedModules = new Set<Module>([module]);
+  const stack = [module];
+
+  while (stack.length > 0) {
+    const currentModule = stack.pop();
+    if (!currentModule) continue;
+    const mgm = compilation.moduleGraph._getModuleGraphModule(currentModule);
+    if (mgm && mgm.outgoingConnections) {
+      for (const connection of mgm.outgoingConnections) {
+        if (type === 'initial') {
+          const parentBlock = compilation.moduleGraph.getParentBlock(
+            connection.dependency,
+          );
+          if (parentBlock instanceof AsyncDependenciesBlock) {
+            continue;
+          }
+        }
+        if (connection.module && !collectedModules.has(connection.module)) {
+          collectedModules.add(connection.module);
+          stack.push(connection.module);
+        }
+      }
+    }
+  }
+
+  return collectedModules;
+}
+
 export default HoistContainerReferences;

packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts

@@ -382,6 +382,7 @@ class FederationRuntimePlugin {
         // hoist all modules of federation entry
         this.getFilePath(),
         this.bundlerRuntimePath,
+        this.options.experiments,
       ).apply(compiler);
 
       new compiler.webpack.NormalModuleReplacementPlugin(