Merge 3c0b448 into 0285f5f

Author: ScriptedAlchemy

packages/rsbuild-plugin/rslib.config.ts

@@ -1,5 +1,6 @@
 import { pluginPublint } from 'rsbuild-plugin-publint';
 import { defineConfig } from '@rslib/core';
+import pkg from './package.json';
 
 export default defineConfig({
   plugins: [pluginPublint()],
@@ -30,6 +31,9 @@ export default defineConfig({
         '!./src/**/*.test.*',
       ],
     },
+    define: {
+      __RSBUILD_PLUGIN_NAME__: JSON.stringify(pkg.name),
+    },
     tsconfigPath: './tsconfig.lib.json',
   },
   output: {

packages/rsbuild-plugin/src/cli/index.test.ts

@@ -1,5 +1,7 @@
 import { describe, expect, it } from 'vitest';
 import { pluginModuleFederation } from './index';
+import pkg from '../../package.json';
+import { CALL_NAME_MAP } from '../constant';
 import type { moduleFederationPlugin } from '@module-federation/sdk';
 
 describe('pluginModuleFederation', () => {
@@ -27,4 +29,16 @@ describe('pluginModuleFederation', () => {
     expect(plugin).toBeDefined();
     expect(plugin.name).toBe('rsbuild:module-federation-enhanced');
   });
+
+  it('should use defined plugin name in dual-target guidance error', () => {
+    const plugin = pluginModuleFederation(mockMFConfig, { target: 'dual' });
+    const mockApi = {
+      context: { callerName: CALL_NAME_MAP.RSLIB },
+      getRsbuildConfig: () => ({}),
+    };
+
+    expect(() => plugin.setup(mockApi as any)).toThrow(
+      `Please set ${pkg.name} as global plugin in rslib.config.ts if you set 'target: "dual"'.`,
+    );
+  });
 });

packages/rsbuild-plugin/src/cli/index.ts

@@ -5,7 +5,6 @@ import {
   PLUGIN_NAME,
 } from '@module-federation/enhanced/rspack';
 import { isRequiredVersion, getManifestFileName } from '@module-federation/sdk';
-import pkgJson from '../../package.json';
 import logger from '../logger';
 import {
   isRegExp,
@@ -61,9 +60,10 @@ type ExposedAPIType = {
 };
 export type { ModuleFederationOptions, ExposedAPIType };
 
+declare const __RSBUILD_PLUGIN_NAME__: string;
 const RSBUILD_PLUGIN_MODULE_FEDERATION_NAME =
   'rsbuild:module-federation-enhanced';
-const RSBUILD_PLUGIN_NAME = '@module-federation/rsbuild-plugin';
+const RSBUILD_PLUGIN_NAME = __RSBUILD_PLUGIN_NAME__;
 
 export { RSBUILD_PLUGIN_MODULE_FEDERATION_NAME, PLUGIN_NAME, SSR_DIR };
 
@@ -468,7 +468,7 @@ export const pluginModuleFederation = (
                 const match = shared.some((dep) => {
                   if (
                     (ext as RegExp).test(dep) ||
-                    (ext as RegExp).test(pkgJson.name)
+                    (ext as RegExp).test(RSBUILD_PLUGIN_NAME)
                   ) {
                     sharedModule = dep;
                     return true;
@@ -481,7 +481,7 @@ export const pluginModuleFederation = (
               }
 
               if (typeof ext === 'string') {
-                if (ext === pkgJson.name) {
+                if (ext === RSBUILD_PLUGIN_NAME) {
                   return false;
                 }
 

packages/rsbuild-plugin/vite.config.mts

@@ -1,10 +1,14 @@
 /// <reference types="vitest" />
 import { defineConfig } from 'vite';
+import pkg from './package.json';
 
 import tsconfigPaths from 'vite-tsconfig-paths';
 
 export default defineConfig({
   cacheDir: '../../node_modules/.vite/rsbuild-plugin',
+  define: {
+    __RSBUILD_PLUGIN_NAME__: JSON.stringify(pkg.name),
+  },
 
   plugins: [tsconfigPaths()],