Skip to content

Commit 1cf791f

Browse files
test(NODE-7508): Fix inconsistent wording for prose retryable writes test 6, case 3 (#4913)
1 parent f36b754 commit 1cf791f

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

test/integration/retryable-writes/retryable_writes.spec.prose.test.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -490,33 +490,35 @@ describe('Retryable Writes Spec Prose', () => {
490490
'Case 3: Test that drivers return the correct error when receiving some errors with NoWritesPerformed and some without NoWritesPerformed',
491491
{ requires: { topology: 'replicaset', mongodb: '>=6.0' } },
492492
async () => {
493-
// 2. Configure the client to listen to CommandFailedEvents. In the attached listener, configure a fail point with error
494-
// code `91` (NotWritablePrimary) and the `NoWritesPerformed`, `RetryableError` and `SystemOverloadedError` labels:
493+
// 2. Configure a fail point with error code `91` (ShutdownInProgress) with the `RetryableError` and
494+
// `SystemOverloadedError` error labels:
495495
// ```javascript
496496
// {
497497
// configureFailPoint: "failCommand",
498-
// mode: "alwaysOn",
498+
// mode: {times: 1},
499499
// data: {
500500
// failCommands: ["insert"],
501-
// errorLabels: ["RetryableError", "SystemOverloadedError", "NoWritesPerformed"],
501+
// errorLabels: ["RetryableError", "SystemOverloadedError"],
502502
// errorCode: 91
503503
// }
504504
// }
505505
// ```
506506

507-
// 3. Configure a fail point with error code `91` (ShutdownInProgress) with the `RetryableError` and
508-
// `SystemOverloadedError` error labels but without the `NoWritesPerformed` error label:
507+
// 3. Via the command monitoring CommandFailedEvent, configure a fail point with error code `91` (ShutdownInProgress) and
508+
// the `NoWritesPerformed`, `RetryableError` and `SystemOverloadedError` labels:
509509
// ```javascript
510510
// {
511511
// configureFailPoint: "failCommand",
512-
// mode: {times: 1},
512+
// mode: "alwaysOn",
513513
// data: {
514514
// failCommands: ["insert"],
515-
// errorLabels: ["RetryableError", "SystemOverloadedError"],
515+
// errorLabels: ["RetryableError", "SystemOverloadedError", "NoWritesPerformed"],
516516
// errorCode: 91
517517
// }
518518
// }
519519
// ```
520+
// Configure the second fail point command only if the failed event is for the first error configured in step 2.
521+
520522
const serverCommandStub = sinon
521523
.stub(Server.prototype, 'command')
522524
.callsFake(async function () {

0 commit comments

Comments
 (0)