Fix pilot testflight distribution after recent iTC changes (fastlane#5407)

tmm1 · mfurtak · commit 52b987c82272 · 2016-07-27T11:19:36.000-04:00
* fix pilot testflight distribution
* Updates testflight fix to account for encryption attributes
* fix tests
diff --git a/spaceship/lib/spaceship/tunes/tunes_client.rb b/spaceship/lib/spaceship/tunes/tunes_client.rb
@@ -565,13 +565,8 @@ def update_build_information!(app_id: nil,
                                   feedback_email: nil,
                                   platform: 'ios')
       url = "ra/apps/#{app_id}/platforms/#{platform}/trains/#{train}/builds/#{build_number}/testInformation"
-      r = request(:get) do |req|
-        req.url url
-        req.headers['Content-Type'] = 'application/json'
-      end
-      handle_itc_response(r.body)
 
-      build_info = r.body['data']
+      build_info = get_build_info_for_review(app_id: app_id, train: train, build_number: build_number, platform: platform)
       build_info["details"].each do |current|
         current["whatsNew"]["value"] = whats_new if whats_new
         current["description"]["value"] = description if description
@@ -609,79 +604,70 @@ def submit_testflight_build_for_review!(app_id: nil, train: nil, build_number: n
                                             review_user_name: nil,
                                             review_password: nil,
                                             review_notes: nil,
-                                            encryption: false)
+                                            encryption: false,
+                                            encryption_updated: false,
+                                            is_exempt: false,
+                                            proprietary: false,
+                                            third_party: false)
 
       build_info = get_build_info_for_review(app_id: app_id, train: train, build_number: build_number, platform: platform)
       # Now fill in the values provided by the user
 
       # First the localised values:
-      build_info['testInfo']['details'].each do |current|
+      build_info['details'].each do |current|
         current['whatsNew']['value'] = changelog if changelog
         current['description']['value'] = description if description
         current['feedbackEmail']['value'] = feedback_email if feedback_email
         current['marketingUrl']['value'] = marketing_url if marketing_url
         current['privacyPolicyUrl']['value'] = privacy_policy_url if privacy_policy_url
         current['pageLanguageValue'] = current['language'] # There is no valid reason why we need this, only iTC being iTC
       end
-      build_info['significantChange'] ||= {}
-      build_info['significantChange']['value'] = significant_change
-      build_info['testInfo']['reviewFirstName']['value'] = first_name if first_name
-      build_info['testInfo']['reviewLastName']['value'] = last_name if last_name
-      build_info['testInfo']['reviewPhone']['value'] = phone_number if phone_number
-      build_info['testInfo']['reviewEmail']['value'] = review_email if review_email
-      build_info['testInfo']['reviewAccountRequired']['value'] = (review_user_name.to_s + review_password.to_s).length > 0
-      build_info['testInfo']['reviewUserName']['value'] = review_user_name if review_user_name
-      build_info['testInfo']['reviewPassword']['value'] = review_password if review_password
-      build_info['testInfo']['reviewNotes']['value'] = review_notes if review_notes
+
+      review_info = {
+        "significantChange" => {
+          "value" => significant_change
+        },
+        "buildTestInformationTO" => build_info,
+        "exportComplianceTO" => {
+          "usesEncryption" => {
+            "value" => encryption
+          },
+          "encryptionUpdated" => {
+            "value" => encryption_updated
+          },
+          "isExempt" => {
+            "value" => is_exempt
+          },
+          "containsProprietaryCryptography" => {
+            "value" => proprietary
+          },
+          "containsThirdPartyCryptography" => {
+            "value" => third_party
+          }
+        }
+      }
 
       r = request(:post) do |req| # same URL, but a POST request
-        req.url "ra/apps/#{app_id}/platforms/#{platform}/trains/#{train}/builds/#{build_number}/submit/start"
+        req.url "ra/apps/#{app_id}/platforms/#{platform}/trains/#{train}/builds/#{build_number}/review/submit"
 
-        req.body = build_info.to_json
+        req.body = review_info.to_json
         req.headers['Content-Type'] = 'application/json'
       end
       handle_itc_response(r.body)
-
-      encryption_info = r.body['data']
-      update_encryption_compliance(app_id: app_id,
-                                   train: train,
-                                   build_number: build_number,
-                                   platform: platform,
-                                   encryption_info: encryption_info,
-                                   encryption: encryption)
     end
     # rubocop:enable Metrics/ParameterLists
 
     def get_build_info_for_review(app_id: nil, train: nil, build_number: nil, platform: 'ios')
+      url = "ra/apps/#{app_id}/platforms/#{platform}/trains/#{train}/builds/#{build_number}/testInformation"
       r = request(:get) do |req|
-        req.url "ra/apps/#{app_id}/platforms/#{platform}/trains/#{train}/builds/#{build_number}/submit/start"
+        req.url url
         req.headers['Content-Type'] = 'application/json'
       end
       handle_itc_response(r.body)
 
       r.body['data']
     end
 
-    def update_encryption_compliance(app_id: nil, train: nil, build_number: nil, platform: 'ios', encryption_info: nil, encryption: nil, is_exempt: true, proprietary: false, third_party: false)
-      return unless encryption_info['exportComplianceRequired']
-      # only sometimes this is required
-
-      encryption_info['usesEncryption']['value'] = encryption
-      encryption_info['encryptionUpdated'] ||= {}
-      encryption_info['encryptionUpdated']['value'] = encryption
-      encryption_info['isExempt']['value'] = is_exempt
-      encryption_info['containsProprietaryCryptography']['value'] = proprietary
-      encryption_info['containsThirdPartyCryptography']['value'] = third_party
-
-      r = request(:post) do |req|
-        req.url "ra/apps/#{app_id}/platforms/#{platform}/trains/#{train}/builds/#{build_number}/submit/complete"
-        req.body = encryption_info.to_json
-        req.headers['Content-Type'] = 'application/json'
-      end
-
-      handle_itc_response(r.body)
-    end
-
     #####################################################
     # @!group Submit for Review
     #####################################################
diff --git a/spaceship/spec/tunes/fixtures/testflight_build_info.json b/spaceship/spec/tunes/fixtures/testflight_build_info.json
@@ -0,0 +1,143 @@
+{
+  "data": {
+    "sectionErrorKeys": [],
+    "sectionInfoKeys": [],
+    "sectionWarningKeys": [],
+    "internalStatus": "active",
+    "externalStatus": "submitForReview",
+    "expirationDate": null,
+    "internalExpirationDate": null,
+    "externalExpirationDate": null,
+    "primaryLanguage": "English",
+    "primaryLocaleCode": "en-US",
+    "availableLanguages": ["English"],
+    "details": [{
+      "sectionErrorKeys": [],
+      "sectionInfoKeys": [],
+      "sectionWarningKeys": [],
+      "language": "English",
+      "localeCode": "en-US",
+      "whatsNew": {
+        "value": null,
+        "isEditable": true,
+        "isRequired": true,
+        "errorKeys": null,
+        "maxLength": 4000,
+        "minLength": 4
+      },
+      "description": {
+        "value": null,
+        "isEditable": true,
+        "isRequired": true,
+        "errorKeys": null,
+        "maxLength": 4000,
+        "minLength": 10
+      },
+      "feedbackEmail": {
+        "value": null,
+        "isEditable": true,
+        "isRequired": true,
+        "errorKeys": null,
+        "maxLength": 500,
+        "minLength": 1
+      },
+      "marketingUrl": {
+        "value": null,
+        "isEditable": true,
+        "isRequired": true,
+        "errorKeys": null,
+        "maxLength": 255,
+        "minLength": 1
+      },
+      "privacyPolicyUrl": {
+        "value": null,
+        "isEditable": true,
+        "isRequired": false,
+        "errorKeys": null,
+        "maxLength": 255,
+        "minLength": 1
+      },
+      "privacyPolicyText": null
+    }],
+    "reviewFirstName": {
+      "value": null,
+      "isEditable": true,
+      "isRequired": true,
+      "errorKeys": null,
+      "maxLength": 100,
+      "minLength": 1
+    },
+    "reviewLastName": {
+      "value": null,
+      "isEditable": true,
+      "isRequired": true,
+      "errorKeys": null,
+      "maxLength": 100,
+      "minLength": 1
+    },
+    "reviewPhone": {
+      "value": null,
+      "isEditable": true,
+      "isRequired": true,
+      "errorKeys": null,
+      "maxLength": 20,
+      "minLength": 1
+    },
+    "reviewEmail": {
+      "value": null,
+      "isEditable": true,
+      "isRequired": true,
+      "errorKeys": null,
+      "maxLength": 100,
+      "minLength": 1
+    },
+    "reviewNotes": {
+      "value": null,
+      "isEditable": true,
+      "isRequired": false,
+      "errorKeys": null,
+      "maxLength": 4000,
+      "minLength": 1
+    },
+    "reviewUserName": {
+      "value": null,
+      "isEditable": true,
+      "isRequired": false,
+      "errorKeys": null,
+      "maxLength": 400,
+      "minLength": 1
+    },
+    "reviewPassword": {
+      "value": null,
+      "isEditable": true,
+      "isRequired": false,
+      "errorKeys": null,
+      "maxLength": 400,
+      "minLength": 1
+    },
+    "reviewAccountRequired": {
+      "value": false,
+      "isEditable": true,
+      "isRequired": false,
+      "errorKeys": null
+    },
+    "eula": {
+      "value": null,
+      "isEditable": true,
+      "isRequired": false,
+      "errorKeys": null,
+      "maxLength": null,
+      "minLength": 1
+    },
+    "hasExportCompliance": false,
+    "installCount": 0,
+    "externalInstallCount": 0,
+    "internalInstallCount": 0,
+    "sessionCount": 0,
+    "externalSessionCount": 0,
+    "internalSessionCount": 0,
+    "crashCount": 0,
+    "externalCrashCount": 0,
+    "internalCrashCount": 0
+  }
+}
diff --git a/spaceship/spec/tunes/tunes_stubbing.rb b/spaceship/spec/tunes/tunes_stubbing.rb
@@ -167,16 +167,17 @@ def itc_stub_testers
 end
 
 def itc_stub_testflight
+  # Test information
+  stub_request(:get, "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/apps/898536088/platforms/ios/trains/1.0/builds/10/testInformation").
+    to_return(status: 200, body: itc_read_fixture_file('testflight_build_info.json'), headers: { 'Content-Type' => 'application/json' })
+
   # Reject review
   stub_request(:post, "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/apps/898536088/platforms/ios/trains/1.0/builds/10/reject").
     with(body: "{}").
     to_return(status: 200, body: "{}", headers: { 'Content-Type' => 'application/json' })
 
-  # Prepare submission
-  stub_request(:get, "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/apps/898536088/platforms/ios/trains/1.0/builds/10/submit/start").
-    to_return(status: 200, body: itc_read_fixture_file('testflight_submission_start.json'), headers: { 'Content-Type' => 'application/json' })
-  # First step of submission
-  stub_request(:post, "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/apps/898536088/platforms/ios/trains/1.0/builds/10/submit/start").
+  # Submission
+  stub_request(:post, "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/apps/898536088/platforms/ios/trains/1.0/builds/10/review/submit").
     to_return(status: 200, body: itc_read_fixture_file('testflight_submission_submit.json'), headers: { 'Content-Type' => 'application/json' })
 end
 
