Teach pilot about apps with multiple platforms (fastlane#7267)

* teach pilot about multiple platforms

* use the build platform when updating a build testing status

* pilot is supported on tvos too

* style

* build might be nil

* redundant config

* platform should not be required to list builds

* optional platform for distributing latest build (not from upload)

Author: tmm1

fastlane/lib/fastlane/actions/pilot.rb

@@ -64,7 +64,7 @@ def self.authors
       end
 
       def self.is_supported?(platform)
-        platform == :ios
+        true
       end
     end
   end

pilot/lib/pilot/build_manager.rb

@@ -31,7 +31,7 @@ def upload(options)
       end
 
       UI.message("If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option")
-      uploaded_build = wait_for_processing_build(options) # this might take a while
+      uploaded_build = wait_for_processing_build(options, platform) # this might take a while
 
       distribute(options, uploaded_build)
     end
@@ -43,7 +43,8 @@ def distribute(options, build = nil)
       end
 
       if build.nil?
-        builds = app.all_processing_builds + app.builds
+        platform = fetch_app_platform(required: false)
+        builds = app.all_processing_builds(platform: platform) + app.builds(platform: platform)
         # sort by upload_date
         builds.sort! { |a, b| a.upload_date <=> b.upload_date }
         build = builds.last
@@ -81,12 +82,8 @@ def list(options)
         config[:app_identifier] = UI.input("App Identifier: ")
       end
 
-      if config[:app_platform].to_s.length == 0
-        config[:app_platform] = ask("App Platform (ios, appletvos, osx): ")
-      end
-
-      UI.user_error!("App Platform must be ios, appletvos, or osx") unless ['ios', 'appletvos', 'osx'].include? config[:app_platform]
-      builds = app.all_processing_builds(platform: config[:app_platform]) + app.builds(platform: config[:app_platform])
+      platform = fetch_app_platform(required: false)
+      builds = app.all_processing_builds(platform: platform) + app.builds(platform: platform)
       # sort by upload_date
       builds.sort! { |a, b| a.upload_date <=> b.upload_date }
       rows = builds.collect { |build| describe_build(build) }
@@ -127,8 +124,7 @@ def should_update_build_information(options)
 
     # This method will takes care of checking for the processing builds every few seconds
     # @return [Build] The build that we just uploaded
-
-    def wait_for_processing_build(platform: nil)
+    def wait_for_processing_build(options, platform)
       # the upload date of the new buid
       # we use it to identify the build
       start = Time.now
@@ -144,7 +140,7 @@ def wait_for_processing_build(platform: nil)
         #  build trains right away, and if we don't do this check, we will
         #  get break out of this loop and then generate an error later when we
         #  have a nil build
-        if app.build_trains.count == 0
+        if app.build_trains(platform: platform).count == 0
           UI.message("New application; waiting for build train to appear on iTunes Connect")
         else
           builds = app.all_processing_builds(platform: platform)

pilot/lib/pilot/manager.rb

@@ -57,12 +57,14 @@ def fetch_app_identifier
       return result
     end
 
-    def fetch_app_platform
+    def fetch_app_platform(required: true)
       result = config[:app_platform]
-      result ||= FastlaneCore::IpaFileAnalyser.fetch_app_platform(config[:ipa])
-      result ||= ask("Please enter the app's platform (appletvos, ios, osx): ")
-      UI.user_error!("App Platform must be ios, appletvos, or osx") unless ['ios', 'appletvos', 'osx'].include? result
-      UI.verbose("App Platform (#{result})")
+      result ||= FastlaneCore::IpaFileAnalyser.fetch_app_platform(config[:ipa]) if config[:ipa]
+      if required
+        result ||= ask("Please enter the app's platform (appletvos, ios, osx): ")
+        UI.user_error!("App Platform must be ios, appletvos, or osx") unless ['ios', 'appletvos', 'osx'].include? result
+        UI.verbose("App Platform (#{result})")
+      end
       return result
     end
   end

pilot/lib/pilot/options.rb

@@ -24,7 +24,6 @@ def self.available_options
                                      env_name: "PILOT_PLATFORM",
                                      description: "The platform to use (optional)",
                                      optional: true,
-                                     default_value: "ios",
                                      verify_block: proc do |value|
                                        UI.user_error!("The platform can only be ios, appletvos, or osx") unless ['ios', 'appletvos', 'osx'].include? value
                                      end),

spaceship/lib/spaceship/tunes/build_train.rb

@@ -118,11 +118,12 @@ def latest_build
 
       # @param (testing_type) internal or external
       def update_testing_status!(new_value, testing_type, build = nil)
-        data = client.build_trains(self.application.apple_id, testing_type, platform: self.application.platform)
-
         build ||= latest_build if testing_type == 'external'
+        platform = build ? build.platform : self.application.platform
         testing_key = "#{testing_type}Testing"
 
+        data = client.build_trains(self.application.apple_id, testing_type, platform: platform)
+
         # Delete the irrelevant trains and update the relevant one to enable testing
         data['trains'].delete_if do |train|
           if train['versionString'] != version_string