libstd: Change Path::new to Path::init.#10697
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 29, 2013
Merged
Conversation
|
Need to |
bors
added a commit
that referenced
this pull request
Nov 29, 2013
r+ (carrying over from @alexcrichton's review)
chris-morgan
added a commit
to chris-morgan/rust-http
that referenced
this pull request
Nov 30, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 5, 2023
Ignore `shadow` warns in code from macro expansions This PR fixes rust-lang/rust-clippy#9757 I am in doubt if just looking for `pat.span.from_expansion()` would be sufficient instead of looking for both `pat.span.desugaring_kind().is_some()` or `pat.span.from_expansion()`. The tests (including the new one) passes if I leave the only `if pat.span.from_expansion()`. Any feedbacks? Also, this is my first PR here, sorry for anything and thanks for the patience! changelog: [`shadow_same`, `shadow_reuse`, `shadow_unrelated`]: avoiding warns in macro-generated code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r+
(carrying over from @alexcrichton's review)