Rename Bitwise::population_count to Bitwise::count_ones#12331
Closed
brendanzab wants to merge 1 commit intorust-lang:masterfrom
Closed
Rename Bitwise::population_count to Bitwise::count_ones#12331brendanzab wants to merge 1 commit intorust-lang:masterfrom
brendanzab wants to merge 1 commit intorust-lang:masterfrom
Conversation
Member
|
In addition to the rustdoc-test, could you add a unit test for Other than that, r=me, nice cleanup! |
…se::count_zeros These are inspired by the [functions in the Julia standard library](http://docs.julialang.org/en/release-0.2/stdlib/base/#Base.count_ones).
bors
added a commit
that referenced
this pull request
Feb 17, 2014
This is inspired by the [function naming in the Julia standard library](http://docs.julialang.org/en/release-0.2/stdlib/base/#Base.count_ones). It seems like a more self-explanatory name, and is more consistent with the accompanying methods, `leading_zeros` and `trailing_zeros`.
Closed
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 26, 2024
Rustup r? `@ghost` changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is inspired by the function naming in the Julia standard library. It seems like a more self-explanatory name, and is more consistent with the accompanying methods,
leading_zerosandtrailing_zeros.