Closed
Conversation
Contributor
|
Do you mind making the runtime commit a separate pull request? Thanks... |
Contributor
Author
|
alright, sure |
Contributor
Author
|
it is done |
Contributor
|
/me reads |
Contributor
|
r+ but bitrotted. However, I think you are missing one case, which is default methods. You'll need to adjust the |
Contributor
|
Looks good! |
bors
added a commit
that referenced
this pull request
Aug 21, 2013
For #7083. The metadata issue with the old version is now fixed. Ready for review. This is also not the full solution to #7083, because this is not supported yet: ``` trait Foo : Send { } impl <T: Send> Foo for T { } fn foo<T: Foo>(val: T, chan: std::comm::Chan<T>) { chan.send(val); } ``` cc @nikomatsakis
Contributor
Author
|
sheesh check-fast is my bane today |
bors
added a commit
that referenced
this pull request
Aug 22, 2013
For #7083. The metadata issue with the old version is now fixed. Ready for review. This is also not the full solution to #7083, because this is not supported yet: ``` trait Foo : Send { } impl <T: Send> Foo for T { } fn foo<T: Foo>(val: T, chan: std::comm::Chan<T>) { chan.send(val); } ``` cc @nikomatsakis
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 24, 2022
…nishearth Add lint `cast_enum_constructor` fixes: rust-lang#1116 changelog: Add lint `cast_enum_constructor`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #7083.
The metadata issue with the old version is now fixed. Ready for review.
This is also not the full solution to #7083, because this is not supported yet:
cc @nikomatsakis