Closed
Conversation
Contributor
|
Good work, just had a few nits and comments. I noticed that rustpkg has lots of old style conventions. I think it's fine to ignore my nits because of that in some cases. The main issue is the many different contexts and their poor naming. It would be nice if the abbreviations were consistent and it was always clear what kind of context you had. |
Contributor
Author
|
@metajack Thanks for the careful review! I will address these comments and re-push either today or tomorrow. |
...as well as the ability to discover inputs and outputs.
rustpkg now uses the workcache library to avoid recompilation. Hooray!
Contributor
Author
|
Re-r? @metajack |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2022
…ro, r=giraffate Example for VEC_RESIZE_TO_ZERO changelog: none Example for VEC_RESIZE_TO_ZERO - what we should use instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @metajack or @brson - This pull request makes rustpkg use the workcache library to avoid recompilation.