From 38593b355d0e57d202bba716cc0cbefff2c8126b Mon Sep 17 00:00:00 2001 From: Robert Ing Date: Thu, 28 Sep 2023 23:25:15 -0400 Subject: [PATCH] fix: Prevent logging events from always returning true --- index.js | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/index.js b/index.js index cd3e07d..ef3effb 100644 --- a/index.js +++ b/index.js @@ -139,8 +139,7 @@ var constructor = function() { function logSessionStart(event) { try { - SessionHandler.onSessionStart(event); - return true; + return SessionHandler.onSessionStart(event); } catch (e) { return { error: 'Error starting session on forwarder ' + name + '; ' + e, @@ -150,8 +149,7 @@ var constructor = function() { function logSessionEnd(event) { try { - SessionHandler.onSessionEnd(event); - return true; + return SessionHandler.onSessionEnd(event); } catch (e) { return { error: 'Error ending session on forwarder ' + name + '; ' + e, @@ -161,8 +159,7 @@ var constructor = function() { function logError(event) { try { - self.eventHandler.logError(event); - return true; + return self.eventHandler.logError(event); } catch (e) { return { error: 'Error logging error on forwarder ' + name + '; ' + e, @@ -172,8 +169,7 @@ var constructor = function() { function logPageView(event) { try { - self.eventHandler.logPageView(event); - return true; + return self.eventHandler.logPageView(event); } catch (e) { return { error: @@ -184,8 +180,7 @@ var constructor = function() { function logEvent(event) { try { - self.eventHandler.logEvent(event); - return true; + return self.eventHandler.logEvent(event); } catch (e) { return { error: 'Error logging event on forwarder ' + name + '; ' + e, @@ -195,8 +190,7 @@ var constructor = function() { function logEcommerceEvent(event) { try { - self.commerceHandler.logCommerceEvent(event); - return true; + return self.commerceHandler.logCommerceEvent(event); } catch (e) { return { error: