Skip to content

fix: Prevent logging events from always returning true #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmi22186 merged 1 commit into from
Sep 29, 2023
Merged

fix: Prevent logging events from always returning true #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,7 @@ var constructor = function() {

function logSessionStart(event) {
try {
SessionHandler.onSessionStart(event);
return true;
return SessionHandler.onSessionStart(event);
} catch (e) {
return {
error: 'Error starting session on forwarder ' + name + '; ' + e,
Expand All @@ -150,8 +149,7 @@ var constructor = function() {

function logSessionEnd(event) {
try {
SessionHandler.onSessionEnd(event);
return true;
return SessionHandler.onSessionEnd(event);
} catch (e) {
return {
error: 'Error ending session on forwarder ' + name + '; ' + e,
Expand All @@ -161,8 +159,7 @@ var constructor = function() {

function logError(event) {
try {
self.eventHandler.logError(event);
return true;
return self.eventHandler.logError(event);
} catch (e) {
return {
error: 'Error logging error on forwarder ' + name + '; ' + e,
Expand All @@ -172,8 +169,7 @@ var constructor = function() {

function logPageView(event) {
try {
self.eventHandler.logPageView(event);
return true;
return self.eventHandler.logPageView(event);
} catch (e) {
return {
error:
Expand All @@ -184,8 +180,7 @@ var constructor = function() {

function logEvent(event) {
try {
self.eventHandler.logEvent(event);
return true;
return self.eventHandler.logEvent(event);
} catch (e) {
return {
error: 'Error logging event on forwarder ' + name + '; ' + e,
Expand All @@ -195,8 +190,7 @@ var constructor = function() {

function logEcommerceEvent(event) {
try {
self.commerceHandler.logCommerceEvent(event);
return true;
return self.commerceHandler.logCommerceEvent(event);
} catch (e) {
return {
error:
Expand Down