fix: Rollback default change, fixes #200

Author: mperham

Changes.md

@@ -1,5 +1,10 @@
 # connection_pool Changelog
 
+2.5.2
+------
+
+- Rollback inadvertant change to `auto_reload_after_fork` default. [#200]
+
 2.5.1
 ------
 

lib/connection_pool.rb

@@ -39,7 +39,7 @@ class TimeoutError < ::Timeout::Error; end
 # - :auto_reload_after_fork - automatically drop all connections after fork, defaults to true
 #
 class ConnectionPool
-  DEFAULTS = {size: 5, timeout: 5, auto_reload_after_fork: false}.freeze
+  DEFAULTS = {size: 5, timeout: 5, auto_reload_after_fork: true}.freeze
 
   def self.wrap(options, &block)
     Wrapper.new(options, &block)

lib/connection_pool/version.rb

@@ -1,3 +1,3 @@
 class ConnectionPool
-  VERSION = "2.5.1"
+  VERSION = "2.5.2"
 end

test/test_connection_pool.rb

@@ -706,4 +706,29 @@ def test_automatic_after_fork_callback
     _, status = Process.waitpid2(pid)
     assert_predicate(status, :success?)
   end
+
+  def test_ractors
+    begin
+      # TODO Ractor prints a bunch of warnings to the console, no idea
+      # how to turn it off
+      r = Ractor.new do
+        ConnectionPool.new(auto_reload_after_fork: true) { Object.new }
+        true
+      end
+      r.take
+      # should not get here
+      refute true
+    rescue Ractor::RemoteError => re
+      # expected
+      assert re.cause
+      assert_equal Ractor::IsolationError, re.cause.class
+      assert_match(/ConnectionPool::INSTANCES/, re.cause.message)
+    end
+
+    r = Ractor.new do
+      ConnectionPool.new(auto_reload_after_fork: false) { Object.new }
+      true
+    end
+    assert_equal true, r.take
+  end
 end