Add retry details page#101
Merged
mperham merged 4 commits intosidekiq:masterfrom Mar 29, 2012
jcoene:master
Merged
Conversation
lib/sidekiq/web.rb
Outdated
Collaborator
There was a problem hiding this comment.
Use the method parameter, not the instance variable.
web/views/retry.slim
Outdated
Collaborator
There was a problem hiding this comment.
I don't think you need this thead. Use th for the first column's cells instead.
Collaborator
|
This is awesome. Really good stuff, @jcoene! |
Contributor
Author
|
Thanks for the great feedback, fixed the instance variable reference in helper (woops!) and improved the table as per your suggestions. |
Collaborator
|
Oh dear, you missed the most important change: update the changelog to give yourself credit! |
Contributor
Author
|
Ah, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's currently no way to inspect error details for failed jobs with 0.10.0. I was using resque-web and peeking into the "failed" queue, but that's obviously no longer possible. This patch adds similar functionality to Sidekiq's web interface and hopefully allows more people to ditch resque-web.