Make Sidekiq more Resque compatible

[maxjustus]

Resque always namespaces it's keys either with 'resque:' by default, or with a user defined namespace. So to make Sidekiq compatible with existing Resque installations, I've added namespacing support.

In addition, resque-web uses a set under the 'queues' key to determine which queues to display in it's main dashboard, so I've added a client middleware that adds the queue of the job being queued to that set.

I also refactored all the disparate calls to create redis connections into a single class so there's less repetition.

Thanks for a killer lib!

💰

Max

[mperham]

This is great, thanks!

I worry that the redis connection code is becoming a tangled web of config logic so I'd like to abstract this into storage adapters but this is a great start.

[maxjustus]

The only reason I had those ternaries was to silence unnasigned instance variable warnings when running the tests, but yeah I agree they're redundant :)

[fbjork]

Is there a quick how-to on how to enable the ResqueWebCompatability middleware?

[fbjork]

I tried the following:

Sidekiq::Client.middleware.register do
  use Sidekiq::Middleware::Client::ResqueWebCompatability
end

which gives: uninitialized constant Sidekiq::Middleware::Client::ResqueWebCompatability (NameError)

[mperham]

Spelling is fundamental. ;-)

[fbjork]

I copied from:
https://github.com/mperham/sidekiq/pull/12/files#L6R4

I know it's supposed to be Compatibility, but I copied what I saw:)

[mperham]

It will be enabled by default in about 30 minutes.