Refactor Sidekiq::Client to work as instances#1279
Merged
Conversation
mperham
added a commit
that referenced
this pull request
Oct 26, 2013
Refactor Sidekiq::Client to work as instances
dleung
pushed a commit
to dleung/sidekiq
that referenced
this pull request
Nov 4, 2013
|
Thanks for this. Any chance each client can specify their own redis connection as well? .. ie. different queue services/servers in the same project.. |
Collaborator
Author
|
Not at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sidekiq::Client APIs are all class methods, since they meant to ape the Resque API. It would be nice for the Client API to be instance-based with the class methods using a default instance.
First suggested in #1275 by @pkieltyka