set default cap hooks in a pre-deploy task#1348
Merged
mperham merged 1 commit intosidekiq:masterfrom Nov 17, 2013
dleavitt:fix-default-capistrano-hooks
Merged
set default cap hooks in a pre-deploy task#1348mperham merged 1 commit intosidekiq:masterfrom dleavitt:fix-default-capistrano-hooks
mperham merged 1 commit intosidekiq:masterfrom
dleavitt:fix-default-capistrano-hooks
Conversation
Issue: sidekiq default hooks are never added for cap3 Cause: The cap3 sidekiq hooks are added based on a cap setting, the final value of which won't be available until "before deploy." Currently the check is done when the task file is loaded. Solution: Check and possibly add the hooks in a pre-deploy task rather than at the top level of the task file.
Collaborator
There was a problem hiding this comment.
If a deploy is rolled back, shouldn't we start Sidekiq with the old code?
Contributor
Author
There was a problem hiding this comment.
It will. A rollback still runs the deploy:published task at the end. reverted is the equivalent of updated for rollbacks, see: https://github.com/capistrano/capistrano/blob/master/lib/capistrano/tasks/framework.rake#L48
mperham
added a commit
that referenced
this pull request
Nov 17, 2013
set default cap hooks in a pre-deploy task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: sidekiq default hooks are never added for cap3
Cause:
The cap3 sidekiq hooks are added based on a cap setting, the final value of which won't be available until "before deploy." Currently the check is done when the task file is loaded.
Solution:
Check and possibly add the hooks in a pre-deploy task rather than at the top level of the task file.