Remove branches and notifications directives from .travis.yml#1382
Merged
mperham merged 1 commit intosidekiq:masterfrom Dec 5, 2013
petergoldstein:feature/remove_branch_and_notifications_from_travis
Merged
Remove branches and notifications directives from .travis.yml#1382mperham merged 1 commit intosidekiq:masterfrom petergoldstein:feature/remove_branch_and_notifications_from_travis
mperham merged 1 commit intosidekiq:masterfrom
petergoldstein:feature/remove_branch_and_notifications_from_travis
Conversation
mperham
added a commit
that referenced
this pull request
Dec 5, 2013
…d_notifications_from_travis Remove branches and notifications directives from .travis.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if these are here deliberately, or only as a vestige from back in the day, but I'd like to suggest that these directives be removed.
One of the big plusses for Travis is the ability to do CI runs on forked repos and PRs. With the branches restriction this doesn't happen unless development occurs on the master branch. In practice this means that I always wind up making a commit that removes these directives and then rolling it back when I submit a PR.
At the same time we don't want to notify the IRC channel or mailing list every time there's a failed build on a forked repo.
So I suggest removing both these directives. @mperham - your thoughts?