Replaced class and instance level send#1479
Merged
mperham merged 1 commit intosidekiq:masterfrom Feb 14, 2014
seanpdoyle:master
Merged
Replaced class and instance level send#1479mperham merged 1 commit intosidekiq:masterfrom seanpdoyle:master
send#1479mperham merged 1 commit intosidekiq:masterfrom
seanpdoyle:master
Conversation
Replaced with `__send__` from std lib * `send` can now be overridden to be more semantically meaningful * `message.send(user_id)` as opposed to `message.send_message(user_id)` * `__send__` makes it clear that the reflective version is intended
mperham
added a commit
that referenced
this pull request
Feb 14, 2014
Replaced class and instance level `send`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced with
__send__from std libsendcan now be overridden to be more semantically meaningfulmessage.send(user_id)as opposed tomessage.send_message(user_id)__send__makes it clear that the reflective version is intended