Let's try this again...

[sferik]

Use Object#respond_to? to determine which MultiJson API to use.

[jc00ke]

I'd much rather see us use a method like Sidekiq.decode all over the place & check the version in there. Not a fan of introducing those conditionals everywhere.

[mperham]

I'm supposed to add this ugly hack because you don't want to alias dump to encode?

[sferik]

@mperham Encode is aliased to dump, it just throws warnings. If you don't want warnings, you need to feature-detect.

[mperham]

Yeah, I'm saying there's no reason for the warnings. Just support both pairs. dump/load and encode/decode are both perfectly reasonable names.

[sferik]

I've cleaned up the patch, per @jc00ke's suggestion.

[mperham]

Much better, thanks.

[jc00ke]

Yes, much better. Thanks @sferik!

[sferik]

My pleasure.

When MultiJson 2.0 is released and you're ready to upgrade, you should be able to safely remove Sidekiq.[dump|load]_json and then run these commands:

git ls-files *.rb | xargs sed -i '' 's/Sidekiq.load_json/MultiJson.load/g'
git ls-files *.rb | xargs sed -i '' 's/Sidekiq.dump_json/MultiJson.dump/g'

[jc00ke]

I would actually prefer to leave as is and only change what's inside Sidekiq.[dump|load]_json if necessary. No reason to create a greater surface area, and in case we ever want to change/update in the future it'll be easy.