do not halt deployment if no servers are going to run sidekiq workers#199
Merged
mperham merged 1 commit intosidekiq:masterfrom May 18, 2012
bzanchet:do-not-halt-deploys
Merged
do not halt deployment if no servers are going to run sidekiq workers#199mperham merged 1 commit intosidekiq:masterfrom bzanchet:do-not-halt-deploys
mperham merged 1 commit intosidekiq:masterfrom
bzanchet:do-not-halt-deploys
Conversation
|
👍 |
mperham
added a commit
that referenced
this pull request
May 18, 2012
do not halt deployment if no servers are going to run sidekiq workers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capistrano has this option to prevent deploys from being halted if no servers are matched for a given role (it just prints a message and continues).
In our case, we only run sidekiq in about half of our servers, and we deploy to groups of servers at a time to reduce downtime. I had to use this option to prevent the deploy from being interrupted when no servers running sidekiq are included in a given deploy.
Is there a reason to halt the deploy when there's no need to deploy to any servers running sidekiq workers?