Changed &block method argument to yield construction#2188
Merged
mperham merged 2 commits intosidekiq:masterfrom Feb 12, 2015
Merged
Changed &block method argument to yield construction#2188mperham merged 2 commits intosidekiq:masterfrom
mperham merged 2 commits intosidekiq:masterfrom
Conversation
Collaborator
|
lgtm, waiting for travis. |
Contributor
Author
|
@mperham all tests passed 🎉 |
mperham
added a commit
that referenced
this pull request
Feb 12, 2015
Changed &block method argument to yield construction
Collaborator
|
thank you! |
Contributor
Author
|
and you to 🌟 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As you may know
yieldconstruction more faster than&blockin arguments (withblock.call).For example, for me
yieldfaster thanblockto 5 times (ruby 2.1.5; you can see benchmark below).And because that i changed
&blockmethod arguments onyieldconstruction in all methods whereblockisn't need in other methods call.Benchmarks
(all developers love benchmarks 😃)
Code for compare yield and block
Results